Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 6297017: Import firmware compiler flags (Closed)

Created:
9 years, 11 months ago by Che-Liang Chiou
Modified:
9 years ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Import firmware compiler flags If passed into Makefile, firmware compiler flags (CC and CFLAGS) will override old values to make sure that the compiled vboot_reference library has calling convention and alike compatible with the firmware. CL:6257018 had caused buildbot failure due to combination of two reasons: First, the Makefile rule for tlcl_generator that uses HOSTCC, which is not the cross-compiler passed to Makefile, but wrongly passes CFLAGS, rather than stuff like HOSTCFLAGS, into HOSTCC. Second, CL:6257018 changed the behavior of Makefile, and so it did not override CFLAGS value passed by emerge-${BOARD}, which is incompatible with HOSTCC. Thus, this CL preserves the previous the behavior of Makefile that always overrides CFLAGS value received from outside world. See also CL:6355014 BUG=None TEST=See below 1. Run emerge-tegra2_seaboard vboot_reference-firmware successfully, and check if vboot.a is compiled with CFLAGS from u-boot-cflags.mk 2. Run emerge and emerge-${BOARD} vboot_reference successfully Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=34be827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M Makefile View 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Che-Liang Chiou
9 years, 11 months ago (2011-01-27 06:33:40 UTC) #1
Tom Wai-Hong Tam
9 years, 11 months ago (2011-01-27 08:15:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698