Adding web pdf files to the tests

Adding web pdf files to the tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72258

[rohitbm, 2011-01-22 01:21:51]

BUG=63293

Adding a web pdf url to the PDF Runner and Find In PDF tests. 

Sometimes pdf crash doesn't create a dump file so I think in that case Find In
PDF test will catch the pdf crash. crbug.com/70454

[Nirnimesh, 2011-01-22 01:42:22]

http://codereview.chromium.org/6297014/diff/1/functional/find_in_page.py
File functional/find_in_page.py (right):

http://codereview.chromium.org/6297014/diff/1/functional/find_in_page.py#newc...
functional/find_in_page.py:242: # Search in the disk pdf file
Search in pdf over file://

http://codereview.chromium.org/6297014/diff/1/functional/find_in_page.py#newc...
functional/find_in_page.py:248: # Search in the web pdf file
Search in pdf over http://

http://codereview.chromium.org/6297014/diff/1/functional/pdf.py
File functional/pdf.py (right):

http://codereview.chromium.org/6297014/diff/1/functional/pdf.py#newcode44
functional/pdf.py:44: # Adding a web pdf file url to the list of pdf files.
Add pdf files over http://

http://codereview.chromium.org/6297014/diff/1/functional/pdf.py#newcode46
functional/pdf.py:46: pdf_files = pdf_files +
['http://www.irs.gov/pub/irs-pdf/fw4.pdf']
pdf_files += ['http...']

[rohitbm, 2011-01-22 02:07:28]

I have uploaded the code with changes.

Thanks,
Rohit

On 2011/01/22 01:42:22, Nirnimesh wrote:
> http://codereview.chromium.org/6297014/diff/1/functional/find_in_page.py
> File functional/find_in_page.py (right):
> 
>
http://codereview.chromium.org/6297014/diff/1/functional/find_in_page.py#newc...
> functional/find_in_page.py:242: # Search in the disk pdf file
> Search in pdf over file://
Done.
> 
>
http://codereview.chromium.org/6297014/diff/1/functional/find_in_page.py#newc...
> functional/find_in_page.py:248: # Search in the web pdf file
> Search in pdf over http://
Done.
> 
> http://codereview.chromium.org/6297014/diff/1/functional/pdf.py
> File functional/pdf.py (right):
> 
> http://codereview.chromium.org/6297014/diff/1/functional/pdf.py#newcode44
> functional/pdf.py:44: # Adding a web pdf file url to the list of pdf files.
> Add pdf files over http://
Done.
> 
> http://codereview.chromium.org/6297014/diff/1/functional/pdf.py#newcode46
> functional/pdf.py:46: pdf_files = pdf_files +
> ['http://www.irs.gov/pub/irs-pdf/fw4.pdf']
> pdf_files += ['http...']
Done.

[Nirnimesh, 2011-01-22 02:10:08]

LGTM

http://codereview.chromium.org/6297014/diff/6001/functional/find_in_page.py
File functional/find_in_page.py (right):

http://codereview.chromium.org/6297014/diff/6001/functional/find_in_page.py#n...
functional/find_in_page.py:247: self.assertEqual(8, search_count, 'Failed to
find in the disk pdf file')
update this comment as well

http://codereview.chromium.org/6297014/diff/6001/functional/find_in_page.py#n...
functional/find_in_page.py:251: self.assertEqual(16, search_count, 'Failed to
find in the web pdf file')
and this

[rohitbm, 2011-01-22 02:13:06]

Committed the code.

On 2011/01/22 02:10:08, Nirnimesh wrote:
> LGTM
> 
> http://codereview.chromium.org/6297014/diff/6001/functional/find_in_page.py
> File functional/find_in_page.py (right):
> 
>
http://codereview.chromium.org/6297014/diff/6001/functional/find_in_page.py#n...
> functional/find_in_page.py:247: self.assertEqual(8, search_count, 'Failed to
> find in the disk pdf file')
> update this comment as well
Done.
> 
>
http://codereview.chromium.org/6297014/diff/6001/functional/find_in_page.py#n...
> functional/find_in_page.py:251: self.assertEqual(16, search_count, 'Failed to
> find in the web pdf file')
> and this
Done.