Issue 6297008: The SSL server's RSA private key must be imported with the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6297008: The SSL server's RSA private key must be imported with the... (Closed)

Created:
9 years, 11 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The SSL server's RSA private key must be imported with the KU_KEY_ENCIPHERMENT key usage to support the RSA key exchange algorithm. Remove the incorrect workarounds for this bug. In the SSLServerSocketTest.DataTransfer unit test, do not proceed to data transfer if the SSL connection cannot be established. Not required for fixing this bug: create an RSA private key with all applicable key usage bits to be future-proof. R=hclam BUG=67928 TEST=net_unittests --gtest_filter=SSLServerSocketTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71739

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -14 lines)			Patch
M	base/crypto/rsa_private_key_nss.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download
MM	net/socket/ssl_server_socket_nss.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
MM	net/socket/ssl_server_socket_unittest.cc	View	2 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM! And thanks for explaining to me!

Expand Messages | Collapse Messages