Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: user_collector_test.cc

Issue 6297004: crash-reporter: Add diagnostics to help diagnose failures in the wild (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git@master
Patch Set: clarify Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« user_collector.cc ('K') | « user_collector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: user_collector_test.cc
diff --git a/user_collector_test.cc b/user_collector_test.cc
index 942123fcb08d33850422513319c751e0388a5781..191c2074353992584c7784fc2ac5efb3e7b82317 100644
--- a/user_collector_test.cc
+++ b/user_collector_test.cc
@@ -54,7 +54,8 @@ class UserCollectorTest : public ::testing::Test {
TEST_F(UserCollectorTest, EnableOK) {
ASSERT_TRUE(collector_.Enable());
- ExpectFileEquals("|/my/path --signal=%s --pid=%p", "test/core_pattern");
+ ExpectFileEquals("|/my/path --signal=%s --pid=%p --exec_name=%e",
+ "test/core_pattern");
ExpectFileEquals("4", "test/core_pipe_limit");
ASSERT_EQ(s_crashes, 0);
ASSERT_NE(logging_.log().find("Enabling user crash handling"),
@@ -104,7 +105,7 @@ TEST_F(UserCollectorTest, DisableNoFileAccess) {
TEST_F(UserCollectorTest, HandleCrashWithoutMetrics) {
s_metrics = false;
- collector_.HandleCrash(10, 20, "foobar");
+ collector_.HandleCrash(10, 20, NULL, "foobar");
ASSERT_NE(std::string::npos,
logging_.log().find(
"Received crash notification for foobar[20] sig 10"));
@@ -113,7 +114,7 @@ TEST_F(UserCollectorTest, HandleCrashWithoutMetrics) {
TEST_F(UserCollectorTest, HandleNonChromeCrashWithMetrics) {
s_metrics = true;
- collector_.HandleCrash(2, 5, "chromeos-wm");
+ collector_.HandleCrash(2, 5, NULL, "chromeos-wm");
ASSERT_NE(std::string::npos,
logging_.log().find(
"Received crash notification for chromeos-wm[5] sig 2"));
@@ -122,7 +123,7 @@ TEST_F(UserCollectorTest, HandleNonChromeCrashWithMetrics) {
TEST_F(UserCollectorTest, HandleChromeCrashWithMetrics) {
s_metrics = true;
- collector_.HandleCrash(2, 5, "chrome");
+ collector_.HandleCrash(2, 5, NULL, "chrome");
ASSERT_NE(std::string::npos,
logging_.log().find(
"Received crash notification for chrome[5] sig 2"));
« user_collector.cc ('K') | « user_collector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698