Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: crash_reporter.cc

Issue 6297004: crash-reporter: Add diagnostics to help diagnose failures in the wild (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git@master
Patch Set: clarify Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | system_logging.h » ('j') | system_logging.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crash_reporter.cc
diff --git a/crash_reporter.cc b/crash_reporter.cc
index 07dcd9c5c647b5120384ff9cac8e4cafd12bc0e9..9c2f0ca6f1187a7d2fa0e042e760fd28040f34fc 100644
--- a/crash_reporter.cc
+++ b/crash_reporter.cc
@@ -21,6 +21,7 @@ DEFINE_bool(clean_shutdown, false, "Signal clean shutdown");
DEFINE_string(generate_kernel_signature, "",
"Generate signature from given kcrash file");
DEFINE_bool(crash_test, false, "Crash test");
+DEFINE_string(exec_name, "", "Crashing executable name");
DEFINE_int32(pid, -1, "Crashing PID");
DEFINE_int32(signal, -1, "Signal causing crash");
DEFINE_bool(unclean_check, true, "Check for unclean shutdown");
@@ -142,7 +143,8 @@ static int HandleUserCrash(UserCollector *user_collector) {
}
// Handle the crash, get the name of the process from procfs.
- if (!user_collector->HandleCrash(FLAGS_signal, FLAGS_pid, NULL)) {
+ if (!user_collector->HandleCrash(FLAGS_signal, FLAGS_pid,
+ FLAGS_exec_name.c_str(), NULL)) {
return 1;
}
return 0;
« no previous file with comments | « no previous file | system_logging.h » ('j') | system_logging.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698