Fail gracefully if profile Temp dir can not be accessed.

chrome/browser/extensions/sandboxed_extension_unpacker.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_SANDBOXED_EXTENSION_UNPACKER_H_
 #define CHROME_BROWSER_EXTENSIONS_SANDBOXED_EXTENSION_UNPACKER_H_
 #pragma once
 
 #include <string>
 
 #include "base/file_path.h"
@@ skipping 74 matching lines @@
   // The magic character sequence at the beginning of each crx file.
   static const char kExtensionHeaderMagic[];
 
   // The current version of the crx format.
   static const uint32 kCurrentVersion = 2;
 
   // Unpacks the extension in |crx_path| into a temporary directory and calls
   // |client| with the result. If |rdh| is provided, unpacking is done in a
   // sandboxed subprocess. Otherwise, it is done in-process.
   SandboxedExtensionUnpacker(const FilePath& crx_path,
-                             const FilePath& temp_path,
                              ResourceDispatcherHost* rdh,
                              SandboxedExtensionUnpackerClient* cilent);
 
   // Start unpacking the extension. The client is called with the results.
   void Start();
 
  private:
   class ProcessHostClient;
   friend class ProcessHostClient;
   friend class SandboxedExtensionUnpackerTest;
+  FRIEND_TEST_ALL_PREFIXES(SandboxedExtensionUnpackerTest,
+                           CreateTempDirectory);
 
   virtual ~SandboxedExtensionUnpacker();
 
+  // Creatye a temporary directory to unpack the extension in.
+  // |unpack_path_keys| is a list of PathService keys in which
+  // to place the unpack directory.  A list is used in case some
+  // directories are not writable for any reason.
+  virtual bool CreateTempDirectory(const int unpack_path_keys[],
+                                   size_t unpack_path_keys_size);
+
   // Validates the signature of the extension and extract the key to
   // |public_key_|. Returns true if the signature validates, false otherwise.
   //
   // NOTE: Having this method here is a bit ugly. This code should really live
   // in ExtensionUnpacker as it is not specific to sandboxed unpacking. It was
   // put here because we cannot run windows crypto code in the sandbox. But we
   // could still have this method statically on ExtensionUnpacker so that code
   // just for unpacking is there and code just for sandboxing of unpacking is
   // here.
   bool ValidateSignature();
@@ skipping 14 matching lines @@
   DictionaryValue* RewriteManifestFile(const DictionaryValue& manifest);
 
   // Overwrites original files with safe results from utility process.
   // Reports error and returns false if it fails.
   bool RewriteImageFiles();
   bool RewriteCatalogFiles();
 
   // The path to the CRX to unpack.
   FilePath crx_path_;
 
-  // A path to a temp dir to unpack in.
-  FilePath temp_path_;
-
   // Our client's thread. This is the thread we respond on.
   BrowserThread::ID thread_identifier_;
 
   // ResourceDispatcherHost to pass to the utility process.
   ResourceDispatcherHost* rdh_;
 
   // Our client.
   scoped_refptr<SandboxedExtensionUnpackerClient> client_;
 
   // A temporary directory to use for unpacking.
   ScopedTempDir temp_dir_;
 
   // The root directory of the unpacked extension. This is a child of temp_dir_.
   FilePath extension_root_;
 
   // Represents the extension we're unpacking.
   scoped_refptr<Extension> extension_;
 
   // Whether we've received a response from the utility process yet.
   bool got_response_;
 
   // The public key that was extracted from the CRX header.
   std::string public_key_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_SANDBOXED_EXTENSION_UNPACKER_H_