Fail gracefully if profile Temp dir can not be accessed.

chrome/browser/extensions/convert_web_app.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/convert_web_app.h"
 
 #include <cmath>
 #include <limits>
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/sha2.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/json_value_serializer.h"
 #include "chrome/common/web_apps.h"
 #include "gfx/codec/png_codec.h"
 #include "googleurl/src/gurl.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace keys = extension_manifest_keys;
 
 using base::Time;
 
@@ skipping 42 matching lines @@
   return base::StringPrintf("%i.%i.%i.%i",
                             create_time_exploded.year,
                             create_time_exploded.month,
                             create_time_exploded.day_of_month,
                             static_cast<uint16>(stamp));
 }
 
 scoped_refptr<Extension> ConvertWebAppToExtension(
     const WebApplicationInfo& web_app,
     const Time& create_time) {
-  FilePath user_data_temp_dir;
-  CHECK(PathService::Get(chrome::DIR_USER_DATA_TEMP, &user_data_temp_dir));
+  FilePath user_data_temp_dir = extension_file_util::GetUserDataTempDir();
+  if (user_data_temp_dir.empty()) {
+    LOG(ERROR) << "Could not get path to profile temporary directory.";
+    return NULL;
+  }
 
   ScopedTempDir temp_dir;
   if (!temp_dir.CreateUniqueTempDirUnderPath(user_data_temp_dir)) {
     LOG(ERROR) << "Could not create temporary directory.";
     return NULL;
   }
 
   // Create the manifest
   scoped_ptr<DictionaryValue> root(new DictionaryValue);
   root->SetString(keys::kPublicKey, GenerateKey(web_app.manifest_url));
@@ skipping 67 matching lines @@
   scoped_refptr<Extension> extension = Extension::Create(
       temp_dir.path(), Extension::INTERNAL, *root, false, &error);
   if (!extension) {
     LOG(ERROR) << error;
     return NULL;
   }
 
   temp_dir.Take();  // The caller takes ownership of the directory.
   return extension;
 }