Issue 6296018: Cleanup: Merge common code in RenderView::OnPrintPages and RenderView::OnPrin...

Issue 6296018: Cleanup: Merge common code in RenderView::OnPrintPages and RenderView::OnPrin... (Closed)

Created:
9 years, 11 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
kmadhusu

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Merge common code in RenderView::OnPrintPages and RenderView::OnPrintPreview. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72054

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	chrome/renderer/render_view.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/renderer/render_view.cc	View		3 chunks	+14 lines, -18 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/6296018/diff/1/chrome/renderer/render_view.cc File chrome/renderer/render_view.cc (left): http://codereview.chromium.org/6296018/diff/1/chrome/renderer/render_view.cc#oldcode1175 chrome/renderer/render_view.cc:1175: Print(webview()->focusedFrame(), false, true); Was this a copy+paste mistake or ...

9 years, 11 months ago (2011-01-20 05:47:03 UTC) #1

kmadhusu

9 years, 11 months ago (2011-01-20 17:17:22 UTC) #2

kmadhusu

9 years, 11 months ago (2011-01-20 23:52:03 UTC) #3

On 2011/01/20 17:17:22, kmadhusu wrote:
> http://codereview.chromium.org/6296018/diff/1/chrome/renderer/render_view.cc
> File chrome/renderer/render_view.cc (left):
> 
>
http://codereview.chromium.org/6296018/diff/1/chrome/renderer/render_view.cc#...
> chrome/renderer/render_view.cc:1175: Print(webview()->focusedFrame(), false,
> true);
> On 2011/01/20 05:47:03, Lei Zhang wrote:
> > Was this a copy+paste mistake or was this intentional? Why do we have
if/else
> > clauses that do the same thing?
> 
> It is a mistake. Thanks for fixing it.

LGTM

Expand Messages | Collapse Messages