Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 6296015: Remove eventSender, accessibilityController, plainText and (Closed)

Created:
9 years, 11 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove eventSender, accessibilityController, plainText and textInputController from test_shell. I'll remove layoutTestController in a separate patch since it's bigger. Also remove TestWebViewDelegate::focusAccessibilityObject-- this method was removed from WebKit::WebViewClient a few months ago (https://bugs.webkit.org/show_bug.cgi?id=46707). TEST=test_shell still runs and test_shell_tests still pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1869 lines) Patch
M webkit/glue/context_menu_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
D webkit/tools/test_shell/accessibility_controller.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webkit/tools/test_shell/accessibility_controller.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D webkit/tools/test_shell/event_sending_controller.h View 1 chunk +0 lines, -147 lines 0 comments Download
D webkit/tools/test_shell/event_sending_controller.cc View 1 chunk +0 lines, -1079 lines 0 comments Download
D webkit/tools/test_shell/plain_text_controller.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/tools/test_shell/plain_text_controller.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 4 chunks +0 lines, -14 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 4 chunks +0 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 3 chunks +11 lines, -30 lines 0 comments Download
D webkit/tools/test_shell/text_input_controller.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/tools/test_shell/text_input_controller.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D webkit/tools/test_shell/text_input_controller_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
9 years, 11 months ago (2011-01-19 20:45:56 UTC) #1
commit-bot: I haz the power
No LGTM from reviewers yet.
9 years, 11 months ago (2011-01-19 20:47:13 UTC) #2
dglazkov1
LGTM. Good bye, old buddy. We found a new buddy.
9 years, 11 months ago (2011-01-19 20:48:42 UTC) #3
ojan
9 years, 11 months ago (2011-01-19 21:58:27 UTC) #4
LGTM. Deleting code++

On Wed, Jan 19, 2011 at 12:48 PM, <dglazkov@google.com> wrote:

> LGTM. Good bye, old buddy. We found a new buddy.
>
>
> http://codereview.chromium.org/6296015/
>

Powered by Google App Engine
This is Rietveld 408576698