Add a verbose option to RunCommandCaptureOutput. Not used yet, does not

Add a verbose option to RunCommandCaptureOutput. Not used yet, does not
dump output until after the command has finished, so not useful for
following 'live'.

Change-Id: Ia8562f5e6f8d7ed8af7e188faa68f5cdbba487c6

BUG=chromium-os:11164
TEST=None

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3343f56

[sosa, 2011-01-20 03:40:54]

http://codereview.chromium.org/6296013/diff/1/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6296013/diff/1/lib/cros_build_lib.py#newcode137
lib/cros_build_lib.py:137: output, error = proc.communicate(input)
I'm not sure this completely helps us because if the command hangs, we're kinda
stuck with no output (from the builders).

Perhaps have the command redirect to a file and RunCommand tail -f and
--pid=<pid>

[dgarrett, 2011-01-20 04:05:23]

I'm somewhat uncomfortable with that because someone could pass a command with a
redirection into RunCommandCaptureOutput. If they do, the shell behavior isn't
what you want.


ls > /tmp/test1 > /tmp/test2   # Puts ls output into test2.

[sosa, 2011-01-20 04:13:55]

True but i'm not sure how else to do it ... we could check for a
redirection ... I'm also not sure RunCommand will even allow a
redirection.

On Wed, Jan 19, 2011 at 8:05 PM,  <dgarrett@chromium.org> wrote:
> I'm somewhat uncomfortable with that because someone could pass a command
> with a
> redirection into RunCommandCaptureOutput. If they do, the shell behavior
> isn't
> what you want.
>
>
> ls > /tmp/test1 > /tmp/test2   # Puts ls output into test2.
>
> http://codereview.chromium.org/6296013/
>

[dgarrett, 2011-01-21 00:57:11]

I checked, and no shell processing is being done, which means no piping. It's
probably safe to turn it on, unless we have any funky symbols being passed
around unprocessed.

On 2011/01/20 04:13:55, sosa wrote:
> True but i'm not sure how else to do it ... we could check for a
> redirection ... I'm also not sure RunCommand will even allow a
> redirection.
> 
> On Wed, Jan 19, 2011 at 8:05 PM,  <mailto:dgarrett@chromium.org> wrote:
> > I'm somewhat uncomfortable with that because someone could pass a command
> > with a
> > redirection into RunCommandCaptureOutput. If they do, the shell behavior
> > isn't
> > what you want.
> >
> >
> > ls > /tmp/test1 > /tmp/test2 &nbsp; # Puts ls output into test2.
> >
> > http://codereview.chromium.org/6296013/
> >

[sosa, 2011-01-22 00:11:07]

LGTM

On Thu, Jan 20, 2011 at 4:57 PM,  <dgarrett@chromium.org> wrote:
> I checked, and no shell processing is being done, which means no piping.
> It's
> probably safe to turn it on, unless we have any funky symbols being passed
> around unprocessed.
>
> On 2011/01/20 04:13:55, sosa wrote:
>>
>> True but i'm not sure how else to do it ... we could check for a
>> redirection ... I'm also not sure RunCommand will even allow a
>> redirection.
>
>> On Wed, Jan 19, 2011 at 8:05 PM,  <mailto:dgarrett@chromium.org> wrote:
>> > I'm somewhat uncomfortable with that because someone could pass a
>> > command
>> > with a
>> > redirection into RunCommandCaptureOutput. If they do, the shell behavior
>> > isn't
>> > what you want.
>> >
>> >
>> > ls > /tmp/test1 > /tmp/test2 &nbsp; # Puts ls output into test2.
>> >
>> > http://codereview.chromium.org/6296013/
>> >
>
>
>
> http://codereview.chromium.org/6296013/
>