Fix for regression: Any window of type APP should create APP_POPUP windows.

Fix for regression: Any window of type APP should create APP_POPUP windows.

When code was moved from browser.cc to browser_navigator.cc, the logic for 
spawning popup windows was either mis-copied or copied from a different code 
path; any browser of TYPE_APP (e.g. TYPE_APP_POPUP) should create popup windows 
of TYPE_APP_POPUP.

BUG=chromium-os:11040
TEST=See issue + UI auto tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71876

[stevenjb, 2011-01-19 00:05:16]

Could one of you do a quick review of this small CL? This is a P1 for R9.y.
(I've already checked that this code path on the branch has not changed much so
it will be a simple merge to the branch). Thanks.

[Ben Goodger (Google), 2011-01-19 17:38:19]

LGTM

[Ben Goodger (Google), 2011-01-19 17:38:30]

On 2011/01/19 17:38:19, Ben Goodger wrote:
> LGTM

Can you add a unit test for this though?

[stevenjb, 2011-01-19 21:46:11]

On 2011/01/19 17:38:30, Ben Goodger wrote:
> On 2011/01/19 17:38:19, Ben Goodger wrote:
> > LGTM
> 
> Can you add a unit test for this though?

Done.

[Ben Goodger (Google), 2011-01-19 21:58:16]

LGTM

On Wed, Jan 19, 2011 at 1:46 PM, <stevenjb@chromium.org> wrote:

> On 2011/01/19 17:38:30, Ben Goodger wrote:
>
>> On 2011/01/19 17:38:19, Ben Goodger wrote:
>> > LGTM
>>
>
>  Can you add a unit test for this though?
>>
>
> Done.
>
>
>
> http://codereview.chromium.org/6296011/
>