Issue 6295010: DevTools: re-enable devtools tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6295010: DevTools: re-enable devtools tests. (Closed)

Created:
9 years, 11 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews, Paweł Hajdan Jr., pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DevTools: re-enable devtools tests. BUG=69719 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71957

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Removed obsolete test data. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -196 lines)			Patch
M	chrome/browser/debugger/devtools_sanity_unittest.cc	View	1 2	4 chunks	+3 lines, -70 lines	0 comments	Download
D	chrome/test/data/devtools/completion_on_pause.html	View	1 2	1 chunk	+0 lines, -35 lines	0 comments	Download
D	chrome/test/data/devtools/console_test_page.html	View	1 2	1 chunk	+0 lines, -45 lines	0 comments	Download
D	chrome/test/data/devtools/image.html	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/devtools/image.png	View	1 2	Binary file		0 comments	Download
D	chrome/test/data/devtools/js_page.html	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/test/data/devtools/resource_test.js	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/test/data/devtools/resource_test_page.html	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/devtools/simple_page.html	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

9 years, 11 months ago (2011-01-19 09:13:26 UTC) #2

LGTM

http://codereview.chromium.org/6295010/diff/1/chrome/browser/debugger/devtool...
File chrome/browser/debugger/devtools_sanity_unittest.cc (left):

http://codereview.chromium.org/6295010/diff/1/chrome/browser/debugger/devtool...
chrome/browser/debugger/devtools_sanity_unittest.cc:59: const char
kResourceContentLengthTestPage[] = "files/devtools/image.html";
Please remove the file as well.

Expand Messages | Collapse Messages