CHROMIUM: config: bluetooth: rfkill driver

CHROMIUM: config: bluetooth: rfkill driver

A new "rfkill" driver is added to control BT radio.
A new kernel config variable CONFIG_BT_RFKILL needs to
be configured to include this driver in the kernel.

Three resources are expected by the driver.
One Shutdown GPIO, One Reset Gpio and One reference Clock.
if any/all of the resources can be defined by a platform.

BUG=none
TEST= tested on board that used BCM4329 (ventana)

Signed-off-by: Anantha Idapalapati <aidapalapati@nvidia.com>;

[anantharamaiah, 2011-01-17 11:21:44]

Olof, as part of 4076005, we discussed to rename the file.

I did renamed the file and submitted as a new case. please review the change.

[Olof Johansson, 2011-01-18 19:26:11]

Hi,

The symbols should be renamed too. Could you also please submit this driver for
upstream inclusion? Thanks!

http://codereview.chromium.org/6295009/diff/2001/drivers/misc/bt_rfkill.c
File drivers/misc/bt_rfkill.c (right):

http://codereview.chromium.org/6295009/diff/2001/drivers/misc/bt_rfkill.c#new...
drivers/misc/bt_rfkill.c:2: * drivers/misc/bcm4329_rfkill.c
See now why having filenames in the files themselves is considered harmful?
Please just delete it.

http://codereview.chromium.org/6295009/diff/2001/drivers/misc/bt_rfkill.c#new...
drivers/misc/bt_rfkill.c:35: struct bcm4329_rfkill_data {
No need to call this bcm4329 either, etc.

[anantharamaiah, 2011-01-19 11:58:35]

done the changes. please let me know if the changes are ok for upstream
inclusion.

[Olof Johansson, 2011-01-19 18:31:16]

Hi,

I have only two minor nits left. Your question was whether it's OK to submit for
upstream -- you don't need my approval for that, but yes please do.

http://codereview.chromium.org/6295009/diff/7001/drivers/misc/Kconfig
File drivers/misc/Kconfig (right):

http://codereview.chromium.org/6295009/diff/7001/drivers/misc/Kconfig#newcode396
drivers/misc/Kconfig:396: default n
Default is always n, so no need to include it

http://codereview.chromium.org/6295009/diff/7001/drivers/misc/Makefile
File drivers/misc/Makefile (right):

http://codereview.chromium.org/6295009/diff/7001/drivers/misc/Makefile#newcode32
drivers/misc/Makefile:32: obj-$(CONFIG_IWMC3200TOP)       += iwmc3200top/
Unrelated change (looks like whitespace tab->spaces)

[anantharamaiah, 2011-01-24 09:22:44]

incorporated review comments.