Issue 6295008: Extension - Docs - Add a note where user cannot override newtab incognito windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6295008: Extension - Docs - Add a note where user cannot override newtab incognito windows. (Closed)

Created:
9 years, 11 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman, kathyw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Extension - Docs - Add a note where user cannot override newtab incognito windows. Since new tab pages cannot be overridden in incognito windows, a note should be specified in the documentation. Some users I have seen in IRC and Forums have this confusion. The reason why you cannot override is from the following bug, where extension developers discussed the following issue: http://crbug.com/39372 BUG=None TEST=Open the page and the content will be shown Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72286

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/common/extensions/docs/override.html	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/common/extensions/docs/static/override.html	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kathyw

9 years, 11 months ago (2011-01-18 23:13:25 UTC) #2

One change. Otherwise, LGTM.

http://codereview.chromium.org/6295008/diff/1/chrome/common/extensions/docs/s...
File chrome/common/extensions/docs/static/override.html (right):

http://codereview.chromium.org/6295008/diff/1/chrome/common/extensions/docs/s...
chrome/common/extensions/docs/static/override.html:75: You cannot override the
new tab page in incognito windows.
new tab page -> New Tab page

Expand Messages | Collapse Messages

Issue 6295008: Extension - Docs - Add a note where user cannot override newtab incognito windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Test from msysgit #

Patch Set 3 : Rebased #

Messages