Disable DivI and ModI again until the bug with SafepointWithRegistersAndDoubles is solved.

src/arm/lithium-codegen-arm.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 981 matching lines @@
   }
 }
 
 
 void LCodeGen::DoUnknownOSRValue(LUnknownOSRValue* instr) {
   // Nothing to do.
 }
 
 
 void LCodeGen::DoModI(LModI* instr) {
+  Abort("ModI not implemented");
   class DeferredModI: public LDeferredCode {
    public:
     DeferredModI(LCodeGen* codegen, LModI* instr)
         : LDeferredCode(codegen), instr_(instr) { }
     virtual void Generate() {
       codegen()->DoDeferredGenericBinaryStub(instr_, Token::MOD);
     }
    private:
     LModI* instr_;
   };
@@ skipping 35 matching lines @@
   __ mov(result, Operand(result, ASR, 1));
 
   __ b(al, &done);
   __ bind(&deoptimize);
   DeoptimizeIf(al, instr->environment());
   __ bind(&done);
 }
 
 
 void LCodeGen::DoDivI(LDivI* instr) {
+  Abort("DivI not implemented");
   class DeferredDivI: public LDeferredCode {
    public:
     DeferredDivI(LCodeGen* codegen, LDivI* instr)
         : LDeferredCode(codegen), instr_(instr) { }
     virtual void Generate() {
       codegen()->DoDeferredGenericBinaryStub(instr_, Token::DIV);
     }
    private:
     LDivI* instr_;
   };
@@ skipping 67 matching lines @@
 
 
 void LCodeGen::DoDeferredGenericBinaryStub(LBinaryOperation* instr,
                                            Token::Value op) {
   Register left = ToRegister(instr->left());
   Register right = ToRegister(instr->right());
 
   __ PushSafepointRegistersAndDoubles();
   GenericBinaryOpStub stub(op, OVERWRITE_LEFT, left, right);
   __ CallStub(&stub);
-  RecordSafepointWithRegisters(instr->pointer_map(),
-                               0,
-                               Safepoint::kNoDeoptimizationIndex);
+  RecordSafepointWithRegistersAndDoubles(instr->pointer_map(),

[Søren Thygesen Gjesse, 2011/01/14 15:02:43]

Using safepoint with registers and doubles here does not show any bugs?

Before it did not return the result correctly. It probably worked as
OVERWRITE_LEFT was set.

+                                         0,
+                                         Safepoint::kNoDeoptimizationIndex);
   // Overwrite the stored value of r0 with the result of the stub.
   __ str(r0, MemOperand(sp, DwVfpRegister::kNumAllocatableRegisters *
                         kDoubleSize));
   __ PopSafepointRegistersAndDoubles();
 }
 
 
 void LCodeGen::DoMulI(LMulI* instr) {
   Register scratch = scratch0();
   Register left = ToRegister(instr->left());
@@ skipping 2020 matching lines @@
 
 
 void LCodeGen::DoOsrEntry(LOsrEntry* instr) {
   Abort("DoOsrEntry unimplemented.");
 }
 
 
 #undef __
 
 } }  // namespace v8::internal