Issue 6295004: Disable DivI and ModI again until the bug with SafepointWithRegistersAndDoubles is solved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6295004: Disable DivI and ModI again until the bug with SafepointWithRegistersAndDoubles is solved. (Closed)

Created:
9 years, 11 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Disable DivI and ModI again until the bug with SafepointWithRegistersAndDoubles is solved. BUG= TEST=

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		3 chunks	+5 lines, -3 lines	1 comment	Download
	M	src/frames.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-14 15:02:42 UTC) #2

LGTM

You should open a bug on this.

http://codereview.chromium.org/6295004/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6295004/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1146:
RecordSafepointWithRegistersAndDoubles(instr->pointer_map(),
Using safepoint with registers and doubles here does not show any bugs?

Before it did not return the result correctly. It probably worked as
OVERWRITE_LEFT was set.

Expand Messages | Collapse Messages