Issue 6294016: Move AutoFill messages into a separate file.

Issue 6294016: Move AutoFill messages into a separate file. (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Ilya Sherman, dhollowa

CC:
chromium-reviews, nkostylev+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., James Hawkins, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move AutoFill messages into a separate file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72610

Patch Set 3 : '' #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -300 lines)			Patch
M	chrome/browser/autocomplete_history_manager.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager.cc	View		4 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager_unittest.cc	View	1	3 chunks	+5 lines, -5 lines	1 comment	Download
M	chrome/browser/chromeos/login/account_creation_view.cc	View	1 2	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/password_manager/password_manager.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/password_manager_delegate_impl.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/common/autofill_messages.h	View	1	1 chunk	+125 lines, -0 lines	0 comments	Download
A	chrome/common/autofill_messages.cc	View	1	1 chunk	+104 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View		4 chunks	+0 lines, -30 lines	0 comments	Download
M	chrome/common/render_messages.cc	View		4 chunks	+10 lines, -101 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		5 chunks	+0 lines, -74 lines	0 comments	Download
M	chrome/renderer/autofill_helper.cc	View		9 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/renderer/form_autocomplete_browsertest.cc	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/renderer/password_autocomplete_manager.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/renderer/password_autocomplete_manager_unittest.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view_browsertest.cc	View		6 chunks	+12 lines, -11 lines	0 comments	Download
M	ipc/ipc_message_utils.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dhollowa

Very nice. Some nits. Looks like autofill_manager_unittest.cc got missed according to try bots. http://codereview.chromium.org/6294016/diff/22001/chrome/common/autofill_messages.cc File ...

9 years, 11 months ago (2011-01-26 03:19:39 UTC) #2

Ilya Sherman

Drive-by with nit; otherwise LGTM -- thanks! http://codereview.chromium.org/6294016/diff/27004/chrome/browser/autofill/autofill_manager_unittest.cc File chrome/browser/autofill/autofill_manager_unittest.cc (right): http://codereview.chromium.org/6294016/diff/27004/chrome/browser/autofill/autofill_manager_unittest.cc#newcode27 chrome/browser/autofill/autofill_manager_unittest.cc:27: #include "chrome/common/autofill_messages.h" ...

9 years, 11 months ago (2011-01-26 04:43:11 UTC) #4

jam

On Tue, Jan 25, 2011 at 8:43 PM, <isherman@chromium.org> wrote: > Drive-by with nit; otherwise ...

9 years, 11 months ago (2011-01-26 05:17:54 UTC) #5

LGTM

Expand Messages | Collapse Messages