Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/browser/dom_ui/app_launcher_handler.cc

Issue 6294015: [NTP] Remove app launch animation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyrights Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/app_launcher_handler.h ('k') | chrome/browser/ui/views/app_launched_animation_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/app_launcher_handler.cc
diff --git a/chrome/browser/dom_ui/app_launcher_handler.cc b/chrome/browser/dom_ui/app_launcher_handler.cc
index b5c9142b27e723992b21e598d71387865db9c55c..f8116b56811496202bfcdbc483f003c5c34a2dde 100644
--- a/chrome/browser/dom_ui/app_launcher_handler.cc
+++ b/chrome/browser/dom_ui/app_launcher_handler.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -13,7 +13,6 @@
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "base/values.h"
-#include "chrome/browser/app_launched_animation.h"
#include "chrome/browser/dom_ui/shown_sections_handler.h"
#include "chrome/browser/extensions/default_apps.h"
#include "chrome/browser/extensions/extension_prefs.h"
@@ -305,8 +304,6 @@ void AppLauncherHandler::HandleLaunchApp(const ListValue* args) {
if (browser)
old_contents = browser->GetSelectedTabContents();
- AnimateAppIcon(extension, rect);
-
// Look at preference to find the right launch container. If no preference
// is set, launch as a regular tab.
extension_misc::LaunchContainer launch_container =
@@ -449,19 +446,6 @@ ExtensionInstallUI* AppLauncherHandler::GetExtensionInstallUI() {
return install_ui_.get();
}
-void AppLauncherHandler::AnimateAppIcon(const Extension* extension,
- const gfx::Rect& rect) {
- // We make this check for the case of minimized windows, unit tests, etc.
- if (platform_util::IsVisible(dom_ui_->tab_contents()->GetNativeView()) &&
- ui::Animation::ShouldRenderRichAnimation()) {
-#if defined(OS_WIN)
- AppLaunchedAnimation::Show(extension, rect);
-#else
- NOTIMPLEMENTED();
-#endif
- }
-}
-
void AppLauncherHandler::UninstallDefaultApps() {
DefaultApps* default_apps = extensions_service_->default_apps();
const ExtensionIdSet& app_ids = default_apps->default_apps();
« no previous file with comments | « chrome/browser/dom_ui/app_launcher_handler.h ('k') | chrome/browser/ui/views/app_launched_animation_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698