Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 6294009: Remove a no-longer-used file (build/support/support.gyp).... (Closed)

Created:
9 years, 11 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Remove a no-longer-used file (build/support/support.gyp). (It was always useless and also incorrect, anyway.) Mention of it was removed from chrome_dll.gypi by Nico in r72087, but he was too lazy to remove the file itself. BUG=none TEST=everything builds, and the aforementioned file is no longer there Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
D support.gyp View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
9 years, 11 months ago (2011-01-21 19:18:53 UTC) #1
Nico
9 years, 11 months ago (2011-01-21 19:22:04 UTC) #2
LG

On Fri, Jan 21, 2011 at 11:18 AM,  <viettrungluu@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Remove a no-longer-used file (build/support/support.gyp).
>
> (It was always useless and also incorrect, anyway.) Mention of it was
> removed
> from chrome_dll.gypi by Nico in r72087, but he was too lazy to remove the
> file
> itself.
>
> BUG=none
> TEST=everything builds, and the aforementioned file is no longer there
>
> Please review this at http://codereview.chromium.org/6294009/
>
> SVN Base: svn://chrome-svn/chrome/trunk/deps/support/
>
> Affected files:
>  D     support.gyp
>
>
> Index: support.gyp
> ===================================================================
> --- support.gyp (revision 72168)
> +++ support.gyp (working copy)
> @@ -1,21 +0,0 @@
> -# Copyright (c) 2009 The Chromium Authors. All rights reserved.
> -# Use of this source code is governed by a BSD-style license that can be
> -# found in the LICENSE file.
> -
> -{
> -  'variables': {
> -    'chromium_code': 1,
> -  },
> -  'includes': [
> -    '../../common.gypi',
> -  ],
> -  'targets': [
> -    {
> -      'target_name': 'support',
> -      'type': 'none',
> -    },
> -    # TODO(slightlyoff)
> -  ],
> -}
> -
> -# vim: shiftwidth=2:et:ai:tabstop=2
>
>
>

Powered by Google App Engine
This is Rietveld 408576698