Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 6294008: [Mac] Organize some files into chrome/browser/ui/cocoa/content_settings/.... (Closed)

Created:
9 years, 11 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Mac] Organize some files into chrome/browser/ui/cocoa/content_settings/. BUG=none TEST=none R=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71958

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2705 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/collected_cookies_mac.h View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/ui/cocoa/collected_cookies_mac.mm View 1 chunk +0 lines, -500 lines 0 comments Download
D chrome/browser/ui/cocoa/collected_cookies_mac_unittest.mm View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/cocoa/content_setting_bubble_cocoa.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/ui/cocoa/content_setting_bubble_cocoa.mm View 1 chunk +0 lines, -489 lines 0 comments Download
D chrome/browser/ui/cocoa/content_setting_bubble_cocoa_unittest.mm View 1 chunk +0 lines, -63 lines 0 comments Download
A chrome/browser/ui/cocoa/content_settings/OWNERS View 1 chunk +3 lines, -0 lines 1 comment Download
A + chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_details.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_details.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_details_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_tree_node.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/cookie_tree_node.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/simple_content_exceptions_window_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/simple_content_exceptions_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/content_settings/simple_content_exceptions_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/cookie_details.h View 1 chunk +0 lines, -224 lines 0 comments Download
D chrome/browser/ui/cocoa/cookie_details.mm View 1 chunk +0 lines, -299 lines 0 comments Download
D chrome/browser/ui/cocoa/cookie_details_unittest.mm View 1 chunk +0 lines, -247 lines 0 comments Download
D chrome/browser/ui/cocoa/cookie_details_view_controller.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/ui/cocoa/cookie_details_view_controller.mm View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/ui/cocoa/cookie_details_view_controller_unittest.mm View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/ui/cocoa/cookie_tree_node.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/cocoa/cookie_tree_node.mm View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/options/content_settings_dialog_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/options/cookies_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/options/cookies_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/simple_content_exceptions_window_controller.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/cocoa/simple_content_exceptions_window_controller.mm View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/ui/cocoa/simple_content_exceptions_window_controller_unittest.mm View 1 chunk +0 lines, -94 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
9 years, 11 months ago (2011-01-20 14:22:04 UTC) #1
Nico
Are you planning to do the same for win / linux? I believe the content ...
9 years, 11 months ago (2011-01-20 15:46:22 UTC) #2
Robert Sesek
On 2011/01/20 15:46:22, Nico wrote: > Are you planning to do the same for win ...
9 years, 11 months ago (2011-01-20 15:58:13 UTC) #3
Nico
LG with green mac_rel --clobber try run. http://codereview.chromium.org/6294008/diff/1/chrome/browser/ui/cocoa/content_settings/OWNERS File chrome/browser/ui/cocoa/content_settings/OWNERS (right): http://codereview.chromium.org/6294008/diff/1/chrome/browser/ui/cocoa/content_settings/OWNERS#newcode3 chrome/browser/ui/cocoa/content_settings/OWNERS:3: thakis@chromium.org I ...
9 years, 11 months ago (2011-01-20 16:06:08 UTC) #4
Robert Sesek
9 years, 11 months ago (2011-01-20 16:13:50 UTC) #5
On 2011/01/20 16:06:08, Nico wrote:
> LG with green mac_rel --clobber try run.

http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/54

> chrome/browser/ui/cocoa/content_settings/OWNERS:3: mailto:thakis@chromium.org
> I wonder if this OWNERS file business means that longer term we'll end up with
> directories like
> 
> c/b/ui/feature
> c/b/ui/feature/cocoa
> c/b/ui/feature/gtk
> c/b/ui/feature/views
> 
> because it's a bit strange that the people who wrote the feature model code
> can't change the corresponding view code by default. Anyway :-)

I think Peter brought that up a while ago, and I understand that point. But I
think the counterpoint is that people who write the models aren't necessarily
familiar with a given platform's semantics, so they shouldn't own the
controller/view part. And at least during the porting effort, the two people
usually weren't the same.

Powered by Google App Engine
This is Rietveld 408576698