Split common.sh into bash-only and dash-only sections

Split common.sh into bash-only and dash-only sections

Change-Id: I044331dc3558a4f7428b75fe43ef739498d65803

BUG=chromium-os:10836
TEST=scripts that use common.sh seem to work, would appreciate help in testing Chrome OS client scripts!

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=605500b

[gauravsh, 2011-01-14 01:31:41]

Thieu: Added you as a reviewer for a quick sanity check that this won't break
align_rootfs

Hung-Te: Rest of the change. Would help if you could test the Chrome OS client
scripts still work - I don't have a device handy with me right now.

[Hung-Te, 2011-01-14 03:42:57]

I've verified:
 make_dev_firmware.sh # success
 make_dev_ssd.sh --remove_rootfs_verification # success
 tofactory.sh -b bios.bin -e empty_updater # I'm not really sure about how this
scripts works, but at least it gives me success without error messages.

Besides this change, there are two issues:
 - we need to add common_minimal.sh into the target system, which is currently
handled by the ebuild file.
 - make_dev_firmware.sh calls resign_firmwarefd.sh which uses common.sh now, so
we should either include common.sh or make it dash compatible.

I had a quick check to resign_firmwarefd.sh, looks like it has few non-dash
syntax:
 - type -P is not supported in dash
 - let is not supported in dash

Well, both can be replaced - simply use 'type' without -P, and discard the let.

[gauravsh, 2011-01-14 19:20:39]

On 2011/01/14 03:42:57, Hung-Te wrote:
> I've verified:
>  make_dev_firmware.sh # success
>  make_dev_ssd.sh --remove_rootfs_verification # success
>  tofactory.sh -b bios.bin -e empty_updater # I'm not really sure about how
this
> scripts works, but at least it gives me success without error messages.
> 
> Besides this change, there are two issues:
>  - we need to add common_minimal.sh into the target system, which is currently
> handled by the ebuild file.
>  - make_dev_firmware.sh calls resign_firmwarefd.sh which uses common.sh now,
so
> we should either include common.sh or make it dash compatible.
> 
> I had a quick check to resign_firmwarefd.sh, looks like it has few non-dash
> syntax:
>  - type -P is not supported in dash
>  - let is not supported in dash
> 
> Well, both can be replaced - simply use 'type' without -P, and discard the
let.

Done. I will have the ebuild change in a separate CL.

[Hung-Te, 2011-01-17 05:05:34]

LGTM

[thieule, 2011-01-18 19:02:17]

I've verified align_rootfs.sh works.

On 2011/01/17 05:05:34, Hung-Te wrote:
> LGTM