Added support for GSM in the modemmgr plugin.

Added support for GSM in the modemmgr plugin.
In addition to handling initialization, enable/disable, and
connect/disconnect, it correctly detects network technology
and roaming status.

Refactored property handling code extensively to reduce code
duplication.

This is the first in a series of checkins that will introduce
complete GSM functionality in stages. I'm getting this up for
early review.

BUG=chromium-os:4667
TEST=Tested with new GSM-capable cromo Gobi plugin, in both CDMA
and GSM modes. Manual testing of basic functionality via chrome UI
and command line tools.

Change-Id: I325e46b91d782106774eba6dfe706252d32a8c55

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6601ce5

[Jason Glasgow, 2011-01-13 07:11:08]

http://codereview.chromium.org/6294001/diff/1/src/service.c
File src/service.c (right):

http://codereview.chromium.org/6294001/diff/1/src/service.c#newcode1679
src/service.c:1679: if (network_technology !=
CONNMAN_NETWORK_TECHNOLOGY_UNKNOWN) {
When is network technology ever C_N_TECH..._UNKNOWN?  Would we ever want to send
a single that it is now unknown?

http://codereview.chromium.org/6294001/diff/1/test/mm.sh
File test/mm.sh (right):

http://codereview.chromium.org/6294001/diff/1/test/mm.sh#newcode15
test/mm.sh:15: DEST=`echo $MM | sed -e 's!^/!!g' -e 's!/!.!g'`
Am I missing something?  Why is DEST added?

[Eric Shienbrood, 2011-01-13 07:23:27]

http://codereview.chromium.org/6294001/diff/1/src/service.c
File src/service.c (right):

http://codereview.chromium.org/6294001/diff/1/src/service.c#newcode1679
src/service.c:1679: if (network_technology !=
CONNMAN_NETWORK_TECHNOLOGY_UNKNOWN) {
On 2011/01/13 07:11:08, Jason Glasgow wrote:
> When is network technology ever C_N_TECH..._UNKNOWN?  Would we ever want to
send
> a single that it is now unknown?

Just initially. It really means "not yet known". It will never go back to
UNKNOWN once it has any other value. So I use it here to allow calling this
function to change one but not both of network technology and roaming state.

http://codereview.chromium.org/6294001/diff/1/test/mm.sh
File test/mm.sh (right):

http://codereview.chromium.org/6294001/diff/1/test/mm.sh#newcode15
test/mm.sh:15: DEST=`echo $MM | sed -e 's!^/!!g' -e 's!/!.!g'`
On 2011/01/13 07:11:08, Jason Glasgow wrote:
> Am I missing something?  Why is DEST added?

When I changed the IMODEMS= line, I first did it in the copy of mm.sh that's in
gobi-cromo-plugin. Then I copied that over to here, not noticing that it
contained the extra DEST= line. I've removed that line.

[Eric Shienbrood, 2011-01-13 19:23:22]

PTAL
As I indicated verbally, I've removed the code that saves the LastUpdateTime and
ActivationState.

[Jason Glasgow, 2011-01-14 02:06:44]

LGTM