Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 6293023: PPAPI: move GLES2Implementation to PPAPI glue (Closed)

Created:
9 years, 11 months ago by piman
Modified:
9 years, 7 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, neb
Visibility:
Public.

Description

PPAPI: move GLES2Implementation to PPAPI glue This is in preparation for the proxy for the 3D interface. In the proxy case, we can't have the renderer access the command buffer directly, so we move the command buffer helper instantiation there. A follow-up CL will make that instantiation optional. BUG=none TEST=pepper flash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72913

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -72 lines) Patch
M chrome/renderer/ggl/ggl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/ggl/ggl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/renderer/pepper_platform_context_3d_impl.h View 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/renderer/pepper_platform_context_3d_impl.cc View 2 chunks +45 lines, -36 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 3 chunks +5 lines, -13 lines 0 comments Download
M webkit/plugins/ppapi/ppb_context_3d_impl.h View 3 chunks +9 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_context_3d_impl.cc View 1 6 chunks +54 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppb_surface_3d_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_surface_3d_impl.cc View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
piman
9 years, 11 months ago (2011-01-27 23:53:08 UTC) #1
apatrick_chromium
9 years, 11 months ago (2011-01-28 00:16:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698