Issue 6293017: Fix double allocation of register on arm in DoDeferredMathAbsTaggedHeapNumber...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6293017: Fix double allocation of register on arm in DoDeferredMathAbsTaggedHeapNumber... (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix double allocation of register on arm in DoDeferredMathAbsTaggedHeapNumber. This should fix the sputnik issue on the arm simulator. Priorly tmp2 and tmp3 could potentially be the same register as input. Committed: http://code.google.com/p/v8/source/detail?r=6434

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

This failure where flaky so it did not show up consistently until Kevins (unrelated) change.

9 years, 11 months ago (2011-01-24 07:47:51 UTC) #1

LGTM, thanks!

Expand Messages | Collapse Messages