Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6402)

Unified Diff: chrome/renderer/render_view.cc

Issue 6293007: Add opener frame id, url, and target url to CreateWindow message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index b2f395e444d06fca1b69dadfc0e6fa431504a97d..51432b7ed103262818a89fd50b35145b6a8927f6 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -2073,6 +2073,10 @@ WebView* RenderView::createView(
params.window_container_type = WindowFeaturesToContainerType(features);
params.session_storage_namespace_id = session_storage_namespace_id_;
params.frame_name = frame_name;
+ params.opener_frame_id = creator->identifier();
+ params.opener_url = creator->url();
Johnny(Jianning) Ding 2011/01/17 09:41:15 line 2107 uses creator->securityOrigin() to genera
jochen (gone - plz use gerrit) 2011/01/17 12:11:08 I think creator_url in line 2107 is a bad choice o
+ if (!request.isNull())
+ params.target_url = request.url();
int32 routing_id = MSG_ROUTING_NONE;
int64 cloned_session_storage_namespace_id;
« chrome/common/render_messages_params.h ('K') | « chrome/common/render_messages_params.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698