chrome/browser/extensions/external_extension_loader.cc - Issue 6293006: Allow relative paths to external extension files for some providers, error out for others.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_extension_loader.cc

Issue 6293006: Allow relative paths to external extension files for some providers, error out for others. (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: Tested registry install on windows. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_extension_loader.h ('k') | chrome/browser/extensions/external_extension_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_extension_loader.cc

diff --git a/chrome/browser/extensions/external_extension_loader.cc b/chrome/browser/extensions/external_extension_loader.cc

index 79fc78795315f82afd51a7b9e498420d86896cb6..674cf7d9256bbd7920687042e372f8cec7e53cfc 100644

--- a/chrome/browser/extensions/external_extension_loader.cc

+++ b/chrome/browser/extensions/external_extension_loader.cc

@@ -15,6 +15,13 @@ void ExternalExtensionLoader::Init(

owner_ = owner;

}

+const FilePath ExternalExtensionLoader::GetBaseCrxFilePath() {

+ CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

gfeher 2011/01/14 21:23:17 My understanding is that this will be called on th

Sam Kerner (Chrome) 2011/01/17 20:21:35 Yes, my mistake.

+ // By default, relative paths are not allowed.

+ return FilePath();

void ExternalExtensionLoader::OwnerShutdown() {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

owner_ = NULL;