chrome/browser/system_url_request_context_getter.h - Issue 6292017: Extended: Add "system" URLRequestContext

Side by Side Diff: chrome/browser/system_url_request_context_getter.h

Issue 6292017: Extended: Add "system" URLRequestContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Continued Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/io_thread.cc ('K') | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/system_url_request_context_getter.cc » ('j') | chrome/browser/system_url_request_context_getter.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SYSTEM_URL_REQUEST_CONTEXT_GETTER_H_

	6 #define CHROME_BROWSER_SYSTEM_URL_REQUEST_CONTEXT_GETTER_H_

	7 #pragma once

	8

	9 #include "chrome/common/net/url_request_context_getter.h"

	10

	11 class IOThread;

	12

	13 class SystemURLRequestContextGetter : public URLRequestContextGetter {

	14 public:

	15 explicit SystemURLRequestContextGetter(IOThread* io_thread);
	willchan no longer on Chromium 2011/02/08 22:52:04 We try to make sure there's only 1 URLRequestConte We try to make sure there's only 1 URLRequestContextGetter per URLRequestContext. This subtype does not appear to be able to enforce that, since anyone can publicly create it. I suggest having IOThread have a member variable: mutable scoped_refptr<URLRequestContextGetter> system_url_request_context_getter_; Provide an accessor: scoped_refptr<URLRequestContextGetter> IOThread::system_url_request_context_getter() const; Have this one lazily instantiate it, with the definition in the .cc file. In io_thread.cc, put the SystemURLRequestContextGetter class definition in the anonymous namespace. Implement it there. This way, SystemURLRequestContextGetter is completely hidden from users, the only thing exposed is a way to get a system_url_request_context_getter from the IOThread class. battre 2011/02/14 18:22:05 Done. Show quoted text On 2011/02/08 22:52:04, willchan wrote: > We try to make sure there's only 1 URLRequestContextGetter per > URLRequestContext. This subtype does not appear to be able to enforce that, > since anyone can publicly create it. > > I suggest having IOThread have a member variable: > mutable scoped_refptr<URLRequestContextGetter> > system_url_request_context_getter_; > > Provide an accessor: scoped_refptr<URLRequestContextGetter> > IOThread::system_url_request_context_getter() const; > > Have this one lazily instantiate it, with the definition in the .cc file. > > In io_thread.cc, put the SystemURLRequestContextGetter class definition in the > anonymous namespace. Implement it there. > > This way, SystemURLRequestContextGetter is completely hidden from users, the > only thing exposed is a way to get a system_url_request_context_getter from the > IOThread class. Done.
	16 virtual ~SystemURLRequestContextGetter();

	17

	18 // Implementation for UrlRequestContextGetter.

	19 virtual net::URLRequestContext* GetURLRequestContext();

	20 virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const;

	21

	22 private:

	23 IOThread* io_thread_; // Weak pointer, owned by BrowserProcess.
	willchan no longer on Chromium 2011/02/08 22:52:04 IOThread* const io_thread_; IOThread* const io_thread_; battre 2011/02/14 18:22:05 Done. Show quoted text On 2011/02/08 22:52:04, willchan wrote: > IOThread* const io_thread_; Done.
	24 scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;

	25 };
	willchan no longer on Chromium 2011/02/08 22:52:04 Please add a LeakTracker for this class and assert Please add a LeakTracker for this class and assert in IOThread::CleanUp() that it is deleted. We should make sure people aren't holding onto references to SystemURLRequestContextGetter for too long. battre 2011/02/14 18:22:05 Done. Show quoted text On 2011/02/08 22:52:04, willchan wrote: > Please add a LeakTracker for this class and assert in IOThread::CleanUp() that > it is deleted. We should make sure people aren't holding onto references to > SystemURLRequestContextGetter for too long. Done.
	26

	27 #endif // CHROME_BROWSER_SYSTEM_URL_REQUEST_CONTEXT_GETTER_H_

OLD	NEW