Extended: Add "system" URLRequestContext

chrome/browser/chromeos/proxy_config_service_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_PROXY_CONFIG_SERVICE_IMPL_H_
 #define CHROME_BROWSER_CHROMEOS_PROXY_CONFIG_SERVICE_IMPL_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 21 matching lines @@
 // - provides UI with methods to retrieve and modify system proxy configuration
 //   on UI thread
 // - TODO(kuan): persists proxy configuration settings on chromeos device using
 //   cros settings
 class ProxyConfigServiceImpl
     : public base::RefCountedThreadSafe<ProxyConfigServiceImpl>,
       public SignedSettings::Delegate<bool>,
       public SignedSettings::Delegate<std::string> {
  public:
   // ProxyConfigServiceImpl is created on the UI thread in
-  // chrome/browser/net/chrome_url_request_context.cc::CreateProxyConfigService
-  // via ProfileImpl::GetChromeOSProxyConfigServiceImpl, and stored in Profile
-  // as a scoped_refptr (because it's RefCountedThreadSafe).
+  // chrome/browser/net/proxy_service_factory.cc::CreateProxyConfigService
+  // via BrowserProcess::chromeos_proxy_config_service_impl, and stored in

[willchan no longer on Chromium, 2011/02/21 23:05:49]

Won't it be called multiple times? Once for the BrowserProcess and once per
Profile?

[battre, 2011/03/08 17:38:58]

No, it is stored in g_browser_process. The instance is then recycled for the
profiles:

// static
net::ProxyConfigService* ProxyServiceFactory::CreateProxyConfigService(
    PrefProxyConfigTracker* proxy_config_tracker) {
...
#if defined(OS_CHROMEOS)
  base_service = new chromeos::ProxyConfigService(
      g_browser_process->chromeos_proxy_config_service_impl());
#else
...

+  // g_browser_process as a scoped_refptr (because it's RefCountedThreadSafe).
   //
   // Past that point, it can be accessed from the IO or UI threads.
   //
   // From the IO thread, it is accessed periodically through the wrapper class
   // chromeos::ProxyConfigService via net::ProxyConfigService interface
   // (GetLatestProxyConfig, AddObserver, RemoveObserver).
   //
   // From the UI thread, it is accessed via
-  // WebUI::GetProfile::GetChromeOSProxyConfigServiceImpl to allow user to read
+  // BrowserProcess::chromeos_proxy_config_service_impl to allow user to read
   // or modify the proxy configuration via UIGetProxyConfig or
   // UISetProxyConfigTo* respectively.
   // The new modified proxy config is posted to the IO thread through
   // SetNewProxyConfig().  We then notify observers on the IO thread of the
   // configuration change.
 
   // In contrary to other platforms which simply use the systems' UI to allow
   // users to configure proxies, we have to implement our own UI on the chromeos
   // device.  This requires extra and specific UI requirements that
   // net::ProxyConfig does not suffice.  So we create an augmented analog to
@@ skipping 206 matching lines @@
   // respectively.
   scoped_refptr<SignedSettings> retrieve_property_op_;
   scoped_refptr<SignedSettings> store_property_op_;
 
   DISALLOW_COPY_AND_ASSIGN(ProxyConfigServiceImpl);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_PROXY_CONFIG_SERVICE_IMPL_H_