Issue 6292014: DOMUI Prefs: Remove the startup page managment sub-page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6292014: DOMUI Prefs: Remove the startup page managment sub-page (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI Prefs: Remove the startup page managment sub-page Removes the length restricting from the main page list, and adds the Add button to the button strip there. BUG=70994 TEST=Startup pages should be completely controlable from the Basics page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72857

Patch Set 1 #

Patch Set 2 : Re-add accidentally removed CSS #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -186 lines)			Patch
M	chrome/browser/dom_ui/options/browser_options_handler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/options/options_ui.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
D	chrome/browser/dom_ui/options/startup_page_manager_handler.h	View		1 chunk	+0 lines, -23 lines	0 comments	Download
D	chrome/browser/dom_ui/options/startup_page_manager_handler.cc	View		1 chunk	+0 lines, -28 lines	0 comments	Download
M	chrome/browser/resources/options/add_startup_page_overlay.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/browser_options.html	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.js	View		7 chunks	+28 lines, -22 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options_page.css	View	1	2 chunks	+5 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/options/options.html	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options.js	View		2 chunks	+0 lines, -4 lines	0 comments	Download
D	chrome/browser/resources/options/startup_page_manager.html	View		1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/browser/resources/options/startup_page_manager.js	View		1 chunk	+0 lines, -80 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Love me some deletions. LGTM

Expand Messages | Collapse Messages