Add chunked uploads support to SPDY

net/base/upload_data_stream.h

Index: net/base/upload_data_stream.h
diff --git a/net/base/upload_data_stream.h b/net/base/upload_data_stream.h
index f291140348b7d2acea7b940eee783771fa36e018..75d8387294566d1b7b19a32c1c433aec94ffc3c7 100644
--- a/net/base/upload_data_stream.h
+++ b/net/base/upload_data_stream.h
@@ -27,6 +27,12 @@ class UploadDataStream {
   IOBuffer* buf() const { return buf_; }
   size_t buf_len() const { return buf_len_; }
 
+  // TODO(satish): We should ideally have UploadDataStream expose a Read()
+  // method which returns data in a caller provided IOBuffer. That would do away
+  // with this method and make the interface cleaner as well with less memmove
+  // calls.
+  size_t GetMaxBufferSize() const { return kBufSize; }
+
   // Call to indicate that a portion of the stream's buffer was consumed.  This
   // call modifies the stream's buffer so that it contains the next segment of
   // the upload data to be consumed.
@@ -50,6 +56,16 @@ class UploadDataStream {
   // position < size.
   bool eof() const { return eof_; }
 
+  // Returns whether the data available in buf() includes the last chunk in a
+  // chunked data stream. This method returns true once the final chunk has been
+  // placed in the IOBuffer returned by buf(), in contrast to eof() which
+  // returns true only after the data in buf() has been consumed.
+  bool IsOnLastChunk() const;
+
+#if UNIT_TEST

[willchan no longer on Chromium, 2011/03/03 23:42:32]

most chromium code does defined(UNIT_TEST), not just #if UNIT_TEST. It's
probably best to be consistent.

Please add a TODO to remove this. And I expect you to do this one after you
submit this changelist, because this is kludgy. I think you should add stuff to
UploadData one by one.

[Satish, 2011/03/03 23:50:59]

Will do.
With the current mock read/write testing model, I can't find easily how to break
in the middle of an ongoing sequence and add more chunks to the stream. If you
have any suggestions please let me know, perhaps topic for a separate mail
thread.

+  static void set_merge_chunks(bool merge) { merge_chunks_ = merge; }
+#endif
+
  private:
   enum { kBufSize = 16384 };
 
@@ -93,6 +109,8 @@ class UploadDataStream {
   // Whether there is no data left to read.
   bool eof_;
 
+  static bool merge_chunks_;
+
   DISALLOW_COPY_AND_ASSIGN(UploadDataStream);
 };