Add chunked uploads support to SPDY

net/spdy/spdy_stream.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_STREAM_H_
 #define NET_SPDY_SPDY_STREAM_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/linked_ptr.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/bandwidth_metrics.h"
 #include "net/base/io_buffer.h"
+#include "net/base/upload_data.h"
 #include "net/base/net_log.h"
 #include "net/spdy/spdy_framer.h"
 #include "net/spdy/spdy_protocol.h"
 
 namespace net {
 
 class AddressList;
 class SpdySession;
 class SSLCertRequestInfo;
 class SSLInfo;
 
 // The SpdyStream is used by the SpdySession to represent each stream known
 // on the SpdySession.  This class provides interfaces for SpdySession to use.
 // Streams can be created either by the client or by the server.  When they
 // are initiated by the client, both the SpdySession and client object (such as
 // a SpdyNetworkTransaction) will maintain a reference to the stream.  When
 // initiated by the server, only the SpdySession will maintain any reference,
 // until such a time as a client object requests a stream for the path.
-class SpdyStream : public base::RefCounted<SpdyStream> {
+class SpdyStream
+    : public base::RefCounted<SpdyStream>,
+      public ChunkCallback {
  public:
   // Delegate handles protocol specific behavior of spdy stream.
   class Delegate {
    public:
     Delegate() {}
 
     // Called when SYN frame has been sent.
     // Returns true if no more data to be sent after SYN frame.
     virtual bool OnSendHeadersComplete(int status) = 0;
 
     // Called when stream is ready to send data.
     // Returns network error code. OK when it successfully sent data.
     virtual int OnSendBody() = 0;
 
     // Called when data has been sent. |status| indicates network error
     // or number of bytes has been sent.
     // Returns true if no more data to be sent.
-    virtual bool OnSendBodyComplete(int status) = 0;
+    virtual bool OnSendBodyComplete(int* status) = 0;

[willchan no longer on Chromium, 2011/02/01 23:35:59]

Change this to be more consistent with the rest of the network stack code. If it
needs to return a net error code, return it using the return value. Use a bool*
output parameter for the eof status. Please update the comments too.

[Satish, 2011/02/22 14:25:44]

Done.

 
     // Called when the SYN_STREAM, SYN_REPLY, or HEADERS frames are received.
     // Normal streams will receive a SYN_REPLY and optional HEADERS frames.
     // Pushed streams will receive a SYN_STREAM and optional HEADERS frames.
     // Because a stream may have a SYN_* frame and multiple HEADERS frames,
     // this callback may be called multiple times.
     // |status| indicates network error. Returns network error code.
     virtual int OnResponseReceived(const spdy::SpdyHeaderBlock& response,
                                    base::Time response_time,
                                    int status) = 0;
 
     // Called when data is received.
     virtual void OnDataReceived(const char* data, int length) = 0;
 
     // Called when data is sent.
     virtual void OnDataSent(int length) = 0;
 
     // Called when SpdyStream is closed.
     virtual void OnClose(int status) = 0;
 
+    virtual void set_chunk_callback(ChunkCallback* callback) = 0;

[willchan no longer on Chromium, 2011/02/01 23:35:59]

Please comment this.

+
    protected:
     friend class base::RefCounted<Delegate>;
     virtual ~Delegate() {}
 
    private:
     DISALLOW_COPY_AND_ASSIGN(Delegate);
   };
 
   // SpdyStream constructor
   SpdyStream(SpdySession* session,
@@ skipping 129 matching lines @@
 
   int response_status() const { return response_status_; }
 
   // Returns true if the URL for this stream is known.
   bool HasUrl() const;
 
   // Get the URL associated with this stream.  Only valid when has_url() is
   // true.
   GURL GetUrl() const;
 
+  // ChunkCallback methods.
+  virtual void OnChunkAvailable();
+
  private:
   enum State {
     STATE_NONE,
     STATE_SEND_HEADERS,
     STATE_SEND_HEADERS_COMPLETE,
     STATE_SEND_BODY,
     STATE_SEND_BODY_COMPLETE,
     STATE_WAITING_FOR_RESPONSE,
     STATE_OPEN,
     STATE_DONE
@@ skipping 73 matching lines @@
   int recv_bytes_;
   // Data received before delegate is attached.
   std::vector<scoped_refptr<IOBufferWithSize> > pending_buffers_;
 
   DISALLOW_COPY_AND_ASSIGN(SpdyStream);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_STREAM_H_