Add chunked uploads support to SPDY

net/spdy/spdy_session.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include "base/basictypes.h"
 #include "base/linked_ptr.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 614 matching lines @@
 
     // We only notify the stream when we've fully written the pending frame.
     if (!in_flight_write_.buffer()->BytesRemaining()) {
       if (stream) {
         // Report the number of bytes written to the caller, but exclude the
         // frame size overhead.  NOTE: if this frame was compressed the
         // reported bytes written is the compressed size, not the original
         // size.
         if (result > 0) {
           result = in_flight_write_.buffer()->size();
-          DCHECK_GT(result, static_cast<int>(spdy::SpdyFrame::size()));
+          DCHECK_GE(result, static_cast<int>(spdy::SpdyFrame::size()));

[willchan no longer on Chromium, 2011/02/01 23:35:59]

Why is it a DCHECK_GE now?

[Satish, 2011/02/22 14:25:44]

Per the SPDY spec the last chunk is indicated with a SPDY frame with no data, so
'result' here would be teh same as SpdyFrame::size(). Hence changing GT to GE

           result -= static_cast<int>(spdy::SpdyFrame::size());
         }
 
         // It is possible that the stream was cancelled while we were writing
         // to the socket.
         if (!stream->cancelled())
           stream->OnWriteComplete(result);
       }
 
       // Cleanup the write which just completed.
@@ skipping 835 matching lines @@
   if (it == pending_callback_map_.end())
     return;
 
   CompletionCallback* callback = it->second.callback;
   int result = it->second.result;
   pending_callback_map_.erase(it);
   callback->Run(result);
 }
 
 }  // namespace net