Add chunked uploads support to SPDY

net/base/upload_data_stream.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_UPLOAD_DATA_STREAM_H_
 #define NET_BASE_UPLOAD_DATA_STREAM_H_
 #pragma once
 
 #include "base/scoped_ptr.h"
 #include "net/base/upload_data.h"
 
 namespace net {
 
 class FileStream;
 class IOBuffer;
 
 class UploadDataStream {
  public:
   ~UploadDataStream();
 
   // Returns a new instance of UploadDataStream if it can be created and
   // initialized successfully. If not, NULL will be returned and the error
   // code will be set if the output parameter error_code is not empty.
   static UploadDataStream* Create(UploadData* data, int* error_code);
 
   // Returns the stream's buffer and buffer length.
   IOBuffer* buf() const { return buf_; }
   size_t buf_len() const { return buf_len_; }
 
+  // TODO: We should ideally have UploadDataStream expose a Read() method which

[willchan no longer on Chromium, 2011/03/02 18:44:40]

Put a username on this TODO, either yours or mine. Doesn't mean you have to fix
it, it means someone can ask you for an explanation of what's going on here. I
have plenty of TODO(willchan)s that I probably won't be getting around to.

[Satish, 2011/03/03 13:50:10]

Done.

+  // returns data in a caller provided IOBuffer. That would do away with this
+  // method and make the interface cleaner as well with less memmove calls.
+  size_t GetMaxBufferSize() const { return kBufSize; }
+
   // Call to indicate that a portion of the stream's buffer was consumed.  This
   // call modifies the stream's buffer so that it contains the next segment of
   // the upload data to be consumed.
   void MarkConsumedAndFillBuffer(size_t num_bytes);
 
   // Sets the callback to be invoked when new chunks are available to upload.
   void set_chunk_callback(ChunkCallback* callback) {
     data_->set_chunk_callback(callback);
   }
 
@@ skipping 52 matching lines @@
 
   // Whether there is no data left to read.
   bool eof_;
 
   DISALLOW_COPY_AND_ASSIGN(UploadDataStream);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_UPLOAD_DATA_STREAM_H_