Add chunked uploads support to SPDY

net/base/upload_data_stream.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/upload_data_stream.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "net/base/file_stream.h"
 #include "net/base/io_buffer.h"
@@ skipping 51 matching lines @@
     UploadData::Element& element = elements[next_element_];
 
     size_t size_remaining = kBufSize - buf_len_;
     if (element.type() == UploadData::TYPE_BYTES ||
         element.type() == UploadData::TYPE_CHUNK) {
       const std::vector<char>& d = element.bytes();
       size_t count = d.size() - next_element_offset_;
 
       size_t bytes_copied = std::min(count, size_remaining);
 
-      memcpy(buf_->data() + buf_len_, &d[next_element_offset_], bytes_copied);
+      if (bytes_copied)

[Satish, 2011/01/26 22:36:33]

This check is required because accessing "d[0]" below when d is empty will throw
an exception

[willchan no longer on Chromium, 2011/01/27 18:47:49]

I wonder if it'd be simpler to do:
if (!bytes_copied)
  break;

Not sure what you think here.

[Satish, 2011/01/27 20:42:09]

Sure could do that.

+        memcpy(buf_->data() + buf_len_, &d[next_element_offset_], bytes_copied);
       buf_len_ += bytes_copied;
 
       if (bytes_copied == count) {
         advance_to_next_element = true;
       } else {
         next_element_offset_ += bytes_copied;
       }
     } else {
       DCHECK(element.type() == UploadData::TYPE_FILE);
 
@@ skipping 49 matching lines @@
     if (!data_->is_chunked() ||
         (!elements.empty() && elements.back().is_last_chunk())) {
       eof_ = true;
     }
   }
 
   return OK;
 }
 
 }  // namespace net