Fix autoupdate for hosted apps....

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <set>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 292 matching lines @@
 
   if (!frontend_->extension_prefs()->IsExtensionAllowedByPolicy(
       extension_->id())) {
     ReportFailureFromUIThread("This extension is blacklisted by admin policy.");
     return;
   }
 
   GURL overlapping_url;
   const Extension* overlapping_extension =
       frontend_->GetExtensionByOverlappingWebExtent(extension_->web_extent());
-  if (overlapping_extension) {
+  if (overlapping_extension &&
+      overlapping_extension->id() != extension_->id()) {

[asargent_no_longer_on_chrome, 2011/01/19 17:24:14]

Looking at the code before this patch, you'd wonder if update never worked for
hosted apps. It turns out that if you have "*" as the protocol in your extent,
the GetExtensionByOverlappingWebExtent check will return null, so in some cases
update was working. But that seems like a bug for it to return null, so I've
opened a separate bug (70126) to look into that. 

     ReportFailureFromUIThread(l10n_util::GetStringFUTF8(
         IDS_EXTENSION_OVERLAPPING_WEB_EXTENT,
         UTF8ToUTF16(overlapping_extension->name())));
     return;
   }
 
   current_version_ =
       frontend_->extension_prefs()->GetVersionString(extension_->id());
 
   bool whitelisted = ClearWhitelistedInstallId(extension_->id()) &&
@@ skipping 109 matching lines @@
     client_->OnInstallSuccess(extension_.get(), install_icon_.get());
 
   // Tell the frontend about the installation and hand off ownership of
   // extension_ to it.
   frontend_->OnExtensionInstalled(extension_);
   extension_ = NULL;
 
   // We're done. We don't post any more tasks to ourselves so we are deleted
   // soon.
 }