Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 6292007: Fix autoupdate for hosted apps.... (Closed)

Created:
9 years, 11 months ago by asargent_no_longer_on_chrome
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix autoupdate for hosted apps. The problem is that CrxInstaller wasn't considering updates when looking for previously installed apps with overlapping extents. BUG=68872 TEST=Steps outlined in bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71818

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M chrome/browser/extensions/crx_installer.cc View 1 chunk +2 lines, -1 line 1 comment Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/app_update/key.pem View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/app_update/v1.crx View Binary file 0 comments Download
A chrome/test/data/extensions/app_update/v1/manifest.json View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/app_update/v2.crx View Binary file 0 comments Download
A chrome/test/data/extensions/app_update/v2/manifest.json View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
asargent_no_longer_on_chrome
http://codereview.chromium.org/6292007/diff/1/chrome/browser/extensions/crx_installer.cc File chrome/browser/extensions/crx_installer.cc (right): http://codereview.chromium.org/6292007/diff/1/chrome/browser/extensions/crx_installer.cc#newcode314 chrome/browser/extensions/crx_installer.cc:314: overlapping_extension->id() != extension_->id()) { Looking at the code before ...
9 years, 11 months ago (2011-01-19 17:24:09 UTC) #1
Erik does not do reviews
9 years, 11 months ago (2011-01-19 18:21:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698