Issue 6292003: Add OVERRIDE in the same places the windows version of the file has them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6292003: Add OVERRIDE in the same places the windows version of the file has them. (Closed)

Created:
9 years, 11 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
hans, Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add OVERRIDE in the same places the windows version of the file has them. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71669

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : "oops" #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -22 lines)			Patch
	M	skia/ext/vector_platform_device_linux.h	View	1 2	2 chunks	+25 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

Mostly a linux_clang test. I tried changing the signature of one of the OVERRIDE functions, ...

9 years, 11 months ago (2011-01-17 19:32:15 UTC) #1

hans

9 years, 11 months ago (2011-01-18 08:41:57 UTC) #2

On 2011/01/17 19:32:15, Nico wrote:
> Mostly a linux_clang test.
> 
> I tried changing the signature of one of the OVERRIDE functions, and got a try
> failure for that (at patch set 2, but rietveld didn't notice).

lg

Expand Messages | Collapse Messages