Issue 6291013: Have the ability for the PFQ to both rev Chrome and other packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6291013: Have the ability for the PFQ to both rev Chrome and other packages. (Closed)

Created:
9 years, 11 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
scottz

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Have the ability for the PFQ to both rev Chrome and other packages. This issue seems bigger than it first appears because we had put extra logic to "Delete" the branch if we didn't rev anything. This CL basically takes out all the Deletes and relies and cros_mark_as_stable clean to clean up any old dirs correctly. To do this, I had to fix a bug in clean so that we actually delete the stable branch as part of it (if it exists). EOM Change-Id: Ic1020451dc1d492d4b6e2a233d1d49cf8c1c16b3 BUG=chromium-os:11329 TEST=Ran x86-generic-pfq w/ dev options + --chrome_rev=latest_release ...built chrome, and revved packages without error. Doing more testing still. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8ac0ec Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=436209e

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -97 lines)			Patch
M	bin/cbuildbot.py	View	1 2 3 4 5	3 chunks	+10 lines, -10 lines	0 comments	Download
M	bin/cbuildbot_config.py	View	1 2	5 chunks	+13 lines, -10 lines	0 comments	Download
M	bin/cros_mark_chrome_as_stable.py	View		1 chunk	+6 lines, -12 lines	0 comments	Download
M	cros_mark_as_stable.py	View	1 2 3 4 5 6 7	7 chunks	+32 lines, -25 lines	0 comments	Download
M	cros_mark_as_stable_unittest.py	View	1 2 3	2 chunks	+21 lines, -40 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottz

9 years, 11 months ago (2011-01-27 05:33:37 UTC) #2

LGTM

just one extra new line :) fix and submit

http://codereview.chromium.org/6291013/diff/1/cros_mark_as_stable.py
File cros_mark_as_stable.py (right):

http://codereview.chromium.org/6291013/diff/1/cros_mark_as_stable.py#newcode278
cros_mark_as_stable.py:278: 
extra new line?

Expand Messages | Collapse Messages

Issue 6291013: Have the ability for the PFQ to both rev Chrome and other packages. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Clean up Push #

Patch Set 3 : Whitespace and rebase #

Patch Set 4 : Fix unit tests #

Patch Set 5 : Fix typo #

Patch Set 6 : Fix #

Patch Set 7 : Fix Push issue #

Patch Set 8 : Nit #

Messages