Issue 6291012: Prevent double inialization of DOMUI pref handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6291012: Prevent double inialization of DOMUI pref handlers (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Prevent double inialization of DOMUI pref handlers BUG=66901 TEST=Open DOMUI prefs, then navigate to a different DOMUI prefs URL in the same tab; it should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72521

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bump copyright #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	chrome/browser/dom_ui/options/options_ui.h	View	1	3 chunks	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/dom_ui/options/options_ui.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/6291012/diff/1/chrome/browser/dom_ui/options/options_ui.h File chrome/browser/dom_ui/options/options_ui.h (right): http://codereview.chromium.org/6291012/diff/1/chrome/browser/dom_ui/options/options_ui.h#newcode1 chrome/browser/dom_ui/options/options_ui.h:1: // Copyright (c) 2010 The Chromium Authors. All rights ...

9 years, 11 months ago (2011-01-25 19:05:44 UTC) #3

stuartmorgan

9 years, 11 months ago (2011-01-25 19:08:06 UTC) #4

http://codereview.chromium.org/6291012/diff/1/chrome/browser/dom_ui/options/o...
File chrome/browser/dom_ui/options/options_ui.h (right):

http://codereview.chromium.org/6291012/diff/1/chrome/browser/dom_ui/options/o...
chrome/browser/dom_ui/options/options_ui.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/01/25 19:05:44, csilv wrote:
> bump copyright

Done.

Expand Messages | Collapse Messages