Issue 6291008: Make tweaks to password UI following today's UI review: added a learn more li...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6291008: Make tweaks to password UI following today's UI review: added a learn more li... (Closed)

Created:
9 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, ncarter (slow), finnur+watch_chromium.org, idana, Raghu Simha, jshin+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make tweaks to password UI following today's UI review: added a learn more link on the encryption tab and reduced the amount of text slightly. Made the dialog slightly taller so that everything fits more comfortably without the risk of overlapping elements. BUG=69624 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71908

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/app/resources/locale_settings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/resources/configure.html	View	1 2	3 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_setup_wizard.cc	View		3 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

One nit from review - I thought we wanted ". Please" instead of the semicolon, ...

9 years, 11 months ago (2011-01-20 01:02:48 UTC) #2

John Gregg

9 years, 11 months ago (2011-01-20 02:03:42 UTC) #3

On 2011/01/20 01:02:48, timsteele wrote:
> One nit from review - I thought we wanted ". Please" instead of the semicolon,
> will see if anyone replies on the thread.

Changed.

> 
> LGTM otherwise!
> 
>
http://codereview.chromium.org/6291008/diff/1/chrome/app/resources/locale_set...
> File chrome/app/resources/locale_settings.grd (right):
> 
>
http://codereview.chromium.org/6291008/diff/1/chrome/app/resources/locale_set...
> chrome/app/resources/locale_settings.grd:499: 16
> sanity check: you did check all screens to make sure this didn't accidentally
> shuffle something / misalign a button somewhere, right?

Yeah, everything looks good.

Expand Messages | Collapse Messages