add quiet to arm bootargs

add quiet to arm bootargs

Not printing on the uart makes a huge difference in boot time performance. Since it's easy to re-enable again for those debugging boot time issues, let's disable it by default. It's how x86 does it as well.

Change-Id: Idb4af8d98434e70ee1389b3579c220da34be9c3b

BUG=chromium-os:11351
TEST=Build image and boot system

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e0b7551

[Kenneth Waters, 2011-01-26 18:42:26]

http://codereview.chromium.org/6290011/diff/1/build_kernel_image.sh
File build_kernel_image.sh (right):

http://codereview.chromium.org/6290011/diff/1/build_kernel_image.sh#newcode220
build_kernel_image.sh:220: echo -n 'setenv bootargs ${bootargs} quiet ' >
"${kernel_script}"
use
echo quiet >> "${FLAGS_working_dir}/boot.config"
instead.

That way when you're looking through the build directory you can see what the
kernel command line is.

[Mandeep Singh Baines, 2011-01-26 19:00:20]

olofj@chromium.org (olofj@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines, Kenneth Waters,
> 
> Description:
> add quiet to arm bootargs
> 
> Not printing on the uart makes a huge difference in boot time
> performance. Since
> it's easy to re-enable again for those debugging boot time issues,
> let's disable
> it by default. It's how x86 does it as well.
> 

x86 uses loglevel=1 instead of quiet.

> Change-Id: Idb4af8d98434e70ee1389b3579c220da34be9c3b
> 
> BUG=chromium-os:11351
> TEST=Build image and boot system
> 
> Please review this at http://codereview.chromium.org/6290011/
> 
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
> 
> Affected files:
>   M build_kernel_image.sh
> 
> 
> Index: build_kernel_image.sh
> diff --git a/build_kernel_image.sh b/build_kernel_image.sh
> index
08cca4c726bc1f57f9982bc60f10575ddb6ce90f..5db6bca155ae418247a687473ae709aa6def3b5c
> 100755
> --- a/build_kernel_image.sh
> +++ b/build_kernel_image.sh
> @@ -217,7 +217,7 @@ elif [[ "${FLAGS_arch}" = "arm" ]]; then
>    script_size=16
> 
>    # Build boot script image
> -  echo -n 'setenv bootargs ${bootargs} ' > "${kernel_script}"
> +  echo -n 'setenv bootargs ${bootargs} quiet ' > "${kernel_script}"
>    tr '\n' ' ' <"${FLAGS_working_dir}/boot.config" >> "${kernel_script}"
>    echo >> "${kernel_script}"
>    printf 'read ${devtype} ${devnum}:${kernelpart} ${loadaddr} %x %x\n' \
> 
> 

[Olof Johansson, 2011-01-26 22:06:52]

On 2011/01/26 18:42:26, Kenneth Waters wrote:

> use
> echo quiet >> "${FLAGS_working_dir}/boot.config"
> instead.
> 
> That way when you're looking through the build directory you can see what the
> kernel command line is.

Actually, there's a handful of common args already, I've moved them up there. I
moved rootwait and ro there as well.

[Kenneth Waters, 2011-01-26 22:30:58]

lgtm.