Issue 6290008: Move the TestSink for doing IPC tests from chrome/common into IPC and create ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6290008: Move the TestSink for doing IPC tests from chrome/common into IPC and create ... (Closed)

Created:
9 years, 11 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr., James Hawkins, dhollowa

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move the TestSink for doing IPC tests from chrome/common into IPC and create a new IPC test_support project that references it. This is necessary because I want to make a test that uses the sink outside of chrome. TEST=this is a test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72044

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -164 lines)			Patch
M	chrome/browser/autofill/autofill_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/mock_render_process_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/translate/translate_manager_unittest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -2 lines	0 comments	Download
D	chrome/common/ipc_test_sink.h	View	1 chunk	+0 lines, -91 lines	0 comments	Download
D	chrome/common/ipc_test_sink.cc	View	1 chunk	+0 lines, -59 lines	0 comments	Download
M	chrome/renderer/mock_render_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc.gyp	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A +	ipc/ipc_test_sink.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
A +	ipc/ipc_test_sink.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages