Issue 6290007: Suppresses the leaks for Bug 70062...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6290007: Suppresses the leaks for Bug 70062... (Closed)

Created:
9 years, 11 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Timur Iskhodzhanov

CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Suppresses the leaks for Bug 70062 This change just suppresses the leaks for Bug 70062. (Unfortunately, I'm not totally sure why these leaks happen on these bots because "net/socket/ssl_client_socket_nss.cc" has not been changed these days. Since the only change under 'net/socket' is r71739 <http://crrev.com/71739>;, it emerged these leaks?) TBR=thestig,timurrrr BUG=70062 TEST=make the "Linux Tests (valgrind)(3)" bot and the "Chromium OS UI (valgrind)(3)" bot green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71763

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

9 years, 11 months ago (2011-01-19 11:40:04 UTC) #2

LGTM.

Probably different PK11_ImportDERPrivateKeyInfoAndReturnKey parameters has led
to some different codepaths...

Expand Messages | Collapse Messages