chrome/browser/renderer_host/browser_render_process_host.cc - Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update unit test Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view_gtk.h » ('j') | chrome/browser/renderer_host/text_input_client_message_filter.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/browser_render_process_host.cc

diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc

index f776ac13ccf00c78d695dbfad9b010d5c844b773..c06a09f014cc3bcb790821dde2fba46529c5c3bc 100644

--- a/chrome/browser/renderer_host/browser_render_process_host.cc

+++ b/chrome/browser/renderer_host/browser_render_process_host.cc

@@ -63,6 +63,7 @@

#include "chrome/browser/renderer_host/render_widget_host.h"

#include "chrome/browser/renderer_host/resource_message_filter.h"

#include "chrome/browser/renderer_host/socket_stream_dispatcher_host.h"

+#include "chrome/browser/renderer_host/text_input_client_message_filter.h"

#include "chrome/browser/renderer_host/web_cache_manager.h"

#include "chrome/browser/safe_browsing/client_side_detection_service.h"

#include "chrome/browser/search_engines/search_provider_install_state_message_filter.h"

@@ -483,6 +484,10 @@ void BrowserRenderProcessHost::CreateMessageFilters() {

g_browser_process->resource_dispatcher_host(),

NewCallbackWithReturnValue(

widget_helper_.get(), &RenderWidgetHelper::GetNextRoutingID)));

+#if defined(OS_MACOSX)

+ channel_->AddFilter(new TextInputClientMessageFilter(id()));

+#endif

}

int BrowserRenderProcessHost::GetNextRoutingID() {