chrome/browser/renderer_host/render_widget_host_view_views.cc - Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/render_widget_host_view_mac.mm ('K') | « chrome/browser/renderer_host/render_widget_host_view_views.h ('k') | chrome/browser/renderer_host/text_input_client_mac.h » ('j') | chrome/browser/renderer_host/text_input_client_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_widget_host_view_views.cc

diff --git a/chrome/browser/renderer_host/render_widget_host_view_views.cc b/chrome/browser/renderer_host/render_widget_host_view_views.cc

index 849924f72515812f4f584f8ac927313101424cbc..b6bfbe40d99367a31e001ff5bb356dde61f7e067 100644

--- a/chrome/browser/renderer_host/render_widget_host_view_views.cc

+++ b/chrome/browser/renderer_host/render_widget_host_view_views.cc

@@ -480,7 +480,9 @@ void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) {

// NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove

}

-void RenderWidgetHostViewViews::SelectionChanged(const std::string& text) {

+void RenderWidgetHostViewViews::SelectionChanged(const std::string& text,

+ int start,

+ int end) {

// TODO(anicolao): deal with the clipboard without GTK

NOTIMPLEMENTED();

}