chrome/browser/renderer_host/render_view_host.h - Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_view_host.h

Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Plumb selection rannge with ViewHostMsg_SelectionChanged Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/render_message_filter.h ('K') | « chrome/browser/renderer_host/render_message_filter_mac.mm ('k') | chrome/browser/renderer_host/render_view_host.cc » ('j') | chrome/browser/renderer_host/render_widget_host_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_view_host.h

diff --git a/chrome/browser/renderer_host/render_view_host.h b/chrome/browser/renderer_host/render_view_host.h

index 5278eff06799502e4d201ccd232a80f5253bb980..e49541ad686785deb320a167ce1099a09d2396ff 100644

--- a/chrome/browser/renderer_host/render_view_host.h

+++ b/chrome/browser/renderer_host/render_view_host.h

@@ -607,7 +607,7 @@ class RenderViewHost : public RenderWidgetHost {

void OnMsgGoToEntryAtOffset(int offset);

void OnMsgSetTooltipText(const std::wstring& tooltip_text,

WebKit::WebTextDirection text_direction_hint);

- void OnMsgSelectionChanged(const std::string& text);

+ void OnMsgSelectionChanged(const std::string& text, int start, int end);

void OnMsgPasteFromSelectionClipboard();

void OnMsgRunFileChooser(const ViewHostMsg_RunFileChooser_Params& params);

void OnMsgRunJavaScriptMessage(const std::wstring& message,