Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address jam@ comments Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h" 5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 parent()->RemoveChildView(this); 474 parent()->RemoveChildView(this);
475 MessageLoop::current()->DeleteSoon(FROM_HERE, this); 475 MessageLoop::current()->DeleteSoon(FROM_HERE, this);
476 } 476 }
477 477
478 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) { 478 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) {
479 // TODO(anicolao): decide if we want tooltips for touch (none specified 479 // TODO(anicolao): decide if we want tooltips for touch (none specified
480 // right now/might want a press-and-hold display) 480 // right now/might want a press-and-hold display)
481 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove 481 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove
482 } 482 }
483 483
484 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text) { 484 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text,
485 int start,
486 int end) {
485 // TODO(anicolao): deal with the clipboard without GTK 487 // TODO(anicolao): deal with the clipboard without GTK
486 NOTIMPLEMENTED(); 488 NOTIMPLEMENTED();
487 } 489 }
488 490
489 void RenderWidgetHostViewViews::ShowingContextMenu(bool showing) { 491 void RenderWidgetHostViewViews::ShowingContextMenu(bool showing) {
490 is_showing_context_menu_ = showing; 492 is_showing_context_menu_ = showing;
491 } 493 }
492 494
493 bool RenderWidgetHostViewViews::NeedsInputGrab() { 495 bool RenderWidgetHostViewViews::NeedsInputGrab() {
494 return popup_type_ == WebKit::WebPopupTypeSelect; 496 return popup_type_ == WebKit::WebPopupTypeSelect;
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 } 986 }
985 987
986 // static 988 // static
987 RenderWidgetHostView* 989 RenderWidgetHostView*
988 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView( 990 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
989 gfx::NativeView widget) { 991 gfx::NativeView widget) {
990 gpointer user_data = g_object_get_data(G_OBJECT(widget), 992 gpointer user_data = g_object_get_data(G_OBJECT(widget),
991 kRenderWidgetHostViewKey); 993 kRenderWidgetHostViewKey);
992 return reinterpret_cast<RenderWidgetHostView*>(user_data); 994 return reinterpret_cast<RenderWidgetHostView*>(user_data);
993 } 995 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698