Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h" 5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 parent()->RemoveChildView(this); 473 parent()->RemoveChildView(this);
474 MessageLoop::current()->DeleteSoon(FROM_HERE, this); 474 MessageLoop::current()->DeleteSoon(FROM_HERE, this);
475 } 475 }
476 476
477 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) { 477 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) {
478 // TODO(anicolao): decide if we want tooltips for touch (none specified 478 // TODO(anicolao): decide if we want tooltips for touch (none specified
479 // right now/might want a press-and-hold display) 479 // right now/might want a press-and-hold display)
480 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove 480 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove
481 } 481 }
482 482
483 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text) { 483 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text,
484 int start,
485 int end) {
484 // TODO(anicolao): deal with the clipboard without GTK 486 // TODO(anicolao): deal with the clipboard without GTK
485 NOTIMPLEMENTED(); 487 NOTIMPLEMENTED();
486 } 488 }
487 489
488 void RenderWidgetHostViewViews::ShowingContextMenu(bool showing) { 490 void RenderWidgetHostViewViews::ShowingContextMenu(bool showing) {
489 is_showing_context_menu_ = showing; 491 is_showing_context_menu_ = showing;
490 } 492 }
491 493
492 bool RenderWidgetHostViewViews::NeedsInputGrab() { 494 bool RenderWidgetHostViewViews::NeedsInputGrab() {
493 return popup_type_ == WebKit::WebPopupTypeSelect; 495 return popup_type_ == WebKit::WebPopupTypeSelect;
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 } 970 }
969 971
970 // static 972 // static
971 RenderWidgetHostView* 973 RenderWidgetHostView*
972 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView( 974 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
973 gfx::NativeView widget) { 975 gfx::NativeView widget) {
974 gpointer user_data = g_object_get_data(G_OBJECT(widget), 976 gpointer user_data = g_object_get_data(G_OBJECT(widget),
975 kRenderWidgetHostViewKey); 977 kRenderWidgetHostViewKey);
976 return reinterpret_cast<RenderWidgetHostView*>(user_data); 978 return reinterpret_cast<RenderWidgetHostView*>(user_data);
977 } 979 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698