Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 6289009: [Mac] Implement the system dictionary popup by implementing NSTextInput methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Plumb selection rannge with ViewHostMsg_SelectionChanged Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h" 5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 // TODO(anicolao): deal with any special popup cleanup 296 // TODO(anicolao): deal with any special popup cleanup
297 NOTIMPLEMENTED(); 297 NOTIMPLEMENTED();
298 } 298 }
299 299
300 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) { 300 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) {
301 // TODO(anicolao): decide if we want tooltips for touch (none specified 301 // TODO(anicolao): decide if we want tooltips for touch (none specified
302 // right now/might want a press-and-hold display) 302 // right now/might want a press-and-hold display)
303 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove 303 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove
304 } 304 }
305 305
306 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text) { 306 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text,
307 int start,
308 int end) {
307 // TODO(anicolao): deal with the clipboard without GTK 309 // TODO(anicolao): deal with the clipboard without GTK
308 NOTIMPLEMENTED(); 310 NOTIMPLEMENTED();
309 } 311 }
310 312
311 void RenderWidgetHostViewViews::ShowingContextMenu(bool showing) { 313 void RenderWidgetHostViewViews::ShowingContextMenu(bool showing) {
312 is_showing_context_menu_ = showing; 314 is_showing_context_menu_ = showing;
313 } 315 }
314 316
315 bool RenderWidgetHostViewViews::NeedsInputGrab() { 317 bool RenderWidgetHostViewViews::NeedsInputGrab() {
316 return popup_type_ == WebKit::WebPopupTypeSelect; 318 return popup_type_ == WebKit::WebPopupTypeSelect;
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 } 755 }
754 756
755 // static 757 // static
756 RenderWidgetHostView* 758 RenderWidgetHostView*
757 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView( 759 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
758 gfx::NativeView widget) { 760 gfx::NativeView widget) {
759 gpointer user_data = g_object_get_data(G_OBJECT(widget), 761 gpointer user_data = g_object_get_data(G_OBJECT(widget),
760 kRenderWidgetHostViewKey); 762 kRenderWidgetHostViewKey);
761 return reinterpret_cast<RenderWidgetHostView*>(user_data); 763 return reinterpret_cast<RenderWidgetHostView*>(user_data);
762 } 764 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698