Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6289005: Fixed broken ChromeOS autotests due to http://codereview.chromium.org/5740004... (Closed)

Created:
9 years, 11 months ago by zel
Modified:
9 years, 6 months ago
Reviewers:
zbehan, ericli
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fixed broken ChromeOS autotests due to http://codereview.chromium.org/5740004 TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71809

Patch Set 1 #

Patch Set 2 : '' #

Messages

Total messages: 4 (0 generated)
zel
9 years, 11 months ago (2011-01-15 01:46:35 UTC) #1
zbehan
You also need to change site_chrome_test in the class headers. With that change, everything works. ...
9 years, 11 months ago (2011-01-15 02:25:02 UTC) #2
zbehan
Ping? On Sat, Jan 15, 2011 at 3:24 AM, Zdenek Behan <zbehan@chromium.org> wrote: > You ...
9 years, 11 months ago (2011-01-19 10:33:48 UTC) #3
zbehan
9 years, 11 months ago (2011-01-19 17:45:48 UTC) #4 
I tried it with these changed and it worked, so LGTM.

On Wed, Jan 19, 2011 at 11:33 AM, Zdenek Behan <zbehan@chromium.org> wrote:

> Ping?
>
>
> On Sat, Jan 15, 2011 at 3:24 AM, Zdenek Behan <zbehan@chromium.org> wrote:
>
>> You also need to change site_chrome_test in the class headers.
>>
>> With that change, everything works.
>>
>>
>> On Sat, Jan 15, 2011 at 2:46 AM, <zelidrag@chromium.org> wrote:
>>
>>> Reviewers: ericli, zbehan,
>>>
>>> Description:
>>> Fixed broken ChromeOS autotests due to
>>> http://codereview.chromium.org/5740004
>>>
>>> TEST=none
>>> BUG=none
>>>
>>>
>>> Please review this at http://codereview.chromium.org/6289005/
>>>
>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>>
>>> Affected files:
>>>  M
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py
>>>  M
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py
>>>  M
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py
>>>  M
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/desktopui_UITest.py
>>>
>>>
>>> Index:
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py
>>> ===================================================================
>>> ---
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py
>>>        (revision 71286)
>>> +++
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py
>>>        (working copy)
>>> @@ -2,7 +2,7 @@
>>>  # Use of this source code is governed by a BSD-style license that can be
>>>  # found in the LICENSE file.
>>>
>>> -from autotest_lib.client.bin import site_chrome_test
>>> +from autotest_lib.client.cros import chrome_test
>>>
>>>  class desktopui_BrowserTest(site_chrome_test.ChromeTestBase):
>>>     version = 1
>>> Index:
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py
>>> ===================================================================
>>> ---
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py
>>>    (revision 71286)
>>> +++
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py
>>>    (working copy)
>>> @@ -3,7 +3,7 @@
>>>  # found in the LICENSE file.
>>>
>>>  import os
>>> -from autotest_lib.client.bin import site_chrome_test
>>> +from autotest_lib.client.cros import chrome_test
>>>
>>>  class desktopui_PyAutoFunctionalTests(site_chrome_test.ChromeTestBase):
>>>     """Wrapper for running Chrome's PyAuto-based functional tests."""
>>> Index:
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py
>>> ===================================================================
>>> ---
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py
>>>      (revision 71286)
>>> +++
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_SyncIntegrationTests/desktopui_SyncIntegrationTests.py
>>>      (working copy)
>>> @@ -2,7 +2,7 @@
>>>  # Use of this source code is governed by a BSD-style license that can be
>>>  # found in the LICENSE file.
>>>
>>> -from autotest_lib.client.bin import site_chrome_test
>>> +from autotest_lib.client.cros import chrome_test
>>>
>>>  class desktopui_SyncIntegrationTests(site_chrome_test.ChromeTestBase):
>>>     version = 1
>>> Index:
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/desktopui_UITest.py
>>> ===================================================================
>>> ---
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/desktopui_UITest.py
>>>  (revision 71286)
>>> +++
>>>
chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/desktopui_UITest.py
>>>  (working copy)
>>> @@ -2,7 +2,7 @@
>>>  # Use of this source code is governed by a BSD-style license that can be
>>>  # found in the LICENSE file.
>>>
>>> -from autotest_lib.client.bin import site_chrome_test
>>> +from autotest_lib.client.cros import chrome_test
>>>
>>>  class desktopui_UITest(site_chrome_test.ChromeTestBase):
>>>     version = 1
>>>
>>>
>>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698